Modify

Opened 4 years ago

Last modified 2 years ago

#6647 new defect

[Patch] Voting gets unnecessarily caught by FlashBlock extensions

Reported by: ibboard Owned by: rjollos
Priority: high Component: FiveStarVotePlugin
Severity: minor Keywords:
Cc: Trac Release: 0.11

Description

I've got a FlashBlock script that replaces all <object> tags with a "blocked" element. Even though this hack just uses HTML and JS (although the JS seems superflou superfluous) it gets blocked because of the <object> tag, which is normally used for Flash and the like.

To fix it I just replaced

add_ctxtnav(req, tag.span(tag.object(ul), id='fivestarvotes', title=title, class_=className))

with

add_ctxtnav(req, tag.span(ul, id='fivestarvotes', title=title, class_=className))

in init.py

Attachments (1)

fivestarvote.diff (4.1 KB) - added by ibboard 4 years ago.
Diff of cleaned up code and fixed XHTML generation

Download all attachments as: .zip

Change History (6)

comment:1 Changed 4 years ago by anonymous

Actually, that fix doesn't work because a <span> shouldn't contain a block-level element such as <ul>. I'll attach a fix that is valid XHTML and cleaner code (no links when they're not needed, no unnecessary duplication, etc).

Changed 4 years ago by ibboard

Diff of cleaned up code and fixed XHTML generation

comment:2 Changed 4 years ago by rjollos

  • Owner changed from davglass to rjollos

comment:3 Changed 4 years ago by rjollos

  • Summary changed from Voting gets unnecessarily caught by FlashBlock extensions to [Patch] Voting gets unnecessarily caught by FlashBlock extensions

comment:4 Changed 4 years ago by rjollos

  • Priority changed from low to high
  • Status changed from new to assigned

comment:5 Changed 2 years ago by rjollos

  • Status changed from assigned to new

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.