Ticket #7087 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Trailing spaces are not being removed from the username

Reported by: pablo.grana@globant.com Assigned to: hasienda
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: user register name check
Cc: Trac Release: 0.11

Description

If I add a new user permission with a trailing space in the user name, that space is not removed from the username. So if I add:

'user' 'user ' 'user '

Then I see three times the same user.

So, spaces should be trimmed from the user names, or the space should be somehow marked in the output.

Attachments

Change History

05/06/10 16:55:19 changed by pablo.grana@globant.com

Additional comment: I am using sqlite3 database. The version I'm using does not support trim/ltrim/rtrim fuctions.

10/01/10 23:20:14 changed by hasienda

  • keywords set to user register name check.
  • owner changed from pacopablo to hasienda.
  • status changed from new to assigned.
  • summary changed from Trailing spaces are not being removed from the user name to Trailing spaces are not being removed from the username.

Confirmed by own tests. This is really irritating, since the spaces are even truncated for display in accounts list on user admin page.

I'll try to resolve this for the registration module together with #5295.

10/07/10 14:38:06 changed by hasienda

  • status changed from assigned to closed.
  • resolution set to fixed.

We've got some suggestions and even patches to improve checking for invalid usernames in the registration procedure. Therefore now we've added the following checks in [9260]:

  • against a list of reserved names (refs #5295)
  • against a admin-configurable character blacklist, by default containing
    • colon, since it's corrupting HtPasswdStore (closes #4682)
    • '[' and ']', since they're corrupting SvnServePasswordStore (closes #2630)

Additionally we're taking care of and instantly remove surrounding whitespace around usernames and email addresses (closes #7087).

Thanks to all contributors, especially to manski, for exceptional help by reviewing tickets and bundling related issues.

Add/Change #7087 (Trailing spaces are not being removed from the username)




Change Properties
Action