Modify

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#722 closed defect (fixed)

0.9 branch version of plugin is broken for database upgrade during install process

Reported by: moses@… Owned by: Blackhex
Priority: normal Component: DiscussionPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.9

Description

When you backported updates for 0.10 into the 0.9 version of the plugin, you also inadvertently introduced code that doesn't exist in Trac 0.9, namely the DatabaseManager class. So, files db/db1.py and db/db2.py need to be rolled back. Also, what version of sqlite do you assume? I am having trouble even getting the old updates to work.

Attachments (0)

Change History (4)

comment:1 Changed 8 years ago by Blackhex

  • Resolution set to fixed
  • Status changed from new to closed

I don't know how this could happen :-). Fixed in changeset 1276. Sqlite shoud be version 3 which supports ALTER TABLE ADD COLUMN statement. If you are experiencing problems make sure your pysqlite is using sqlite version 3. If there will be still problems, I could make plugin not use this statement.

comment:2 Changed 8 years ago by moses@…

Hey, updating to pysqlite version 3 fixed my other problems, thanks for the fix and the help.

comment:3 Changed 8 years ago by moses@…

One more thing: it doesn't look like changeset:1276 has rollbacks for db1.py and db2.py

comment:4 Changed 8 years ago by Blackhex

I made two consecutive changesets 1275 and 1276 because I forgot to delete that trac.util.html include.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from Blackhex. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.