Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#7501 closed enhancement (fixed)

Patch for Trac 0.12

Reported by: bne Owned by: cmc
Priority: normal Component: MultiSelectCustomFieldsPatch
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

Hi, attached is an updated diff to cover Trac 0.12

On the face of it, it appears to be working as expected. The usual caveats apply however and as such it should be reviewed and tested extensively before use.

Attachments (2)

multi-fields.012.diff (12.1 KB) - added by bne 4 years ago.
Multi select patch for Trac 0.12
multi-fields.012.tests.diff (3.3 KB) - added by bne 4 years ago.
Correct patched unit tests

Download all attachments as: .zip

Change History (7)

Changed 4 years ago by bne

Multi select patch for Trac 0.12

Changed 4 years ago by bne

Correct patched unit tests

comment:1 Changed 4 years ago by eron

I tried applying the patch but about half of the changes failed to patch correctly. Is anyone still actively working on this?

comment:2 Changed 4 years ago by eron

I got less errors when patching against the latest 0.12stable. Here is the patch output:

patching file trac/ticket/api.py
Hunk #1 succeeded at 363 (offset -17 lines).
patching file trac/ticket/web_ui.py
Hunk #1 succeeded at 1142 (offset 3 lines).
Hunk #2 succeeded at 1403 (offset 8 lines).
Hunk #3 succeeded at 1643 (offset 8 lines).
patching file trac/ticket/model.py
Hunk #1 succeeded at 141 (offset 9 lines).
Hunk #2 succeeded at 151 (offset 9 lines).
Hunk #3 succeeded at 182 with fuzz 1 (offset 9 lines).
patching file trac/ticket/query.py
Hunk #2 FAILED at 339.
Hunk #3 succeeded at 533 (offset -2 lines).
Hunk #4 succeeded at 549 (offset -2 lines).
Hunk #5 succeeded at 675 (offset -2 lines).
Hunk #6 succeeded at 697 (offset -2 lines).
1 out of 6 hunks FAILED -- saving rejects to file trac/ticket/query.py.rej
patching file trac/ticket/templates/ticket.html
patching file trac/ticket/templates/query.html
patching file trac/htdocs/js/query.js
patching file trac/htdocs/css/ticket.css

comment:3 Changed 4 years ago by cmc

  • Status changed from new to assigned

I haven't tried this patch for Trac 0.12; I'll take a look this weekend.

comment:4 Changed 4 years ago by cmc

  • Resolution set to fixed
  • Status changed from assigned to closed

I've added a patch which works against 0.12.1 . Let me know if you run in to any problems.

Thank you kindly to bne for making the initial version of this patch and adding several tests.

comment:5 Changed 4 years ago by eron

Thanks so much for updating it. I'll be able to try it out soon.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.