Modify

Opened 4 years ago

Last modified 20 months ago

#7576 new enhancement

[patch] Users redirected to login screen with no confirmation may fail to recognize that they are registered

Reported by: anonymous Owned by: hasienda
Priority: normal Component: AccountManagerPlugin
Severity: critical Keywords: user register trivial needinfo
Cc: Trac Release: 0.11

Description

When no email verification is used, the user is registered and immediately redirected to login page. Most don't understand this and try registering again and now get message "user already exists".

It should be made clear registered actually succeeded, before redirecting to login.

Attachments (1)

acct_mgr-0.2.1dev_with-7576-fix.png (40.7 KB) - added by hasienda 4 years ago.
Confirmation after successful registration of user «test» in Trac 0.12

Download all attachments as: .zip

Change History (11)

comment:1 follow-up: Changed 4 years ago by rjollos

  • Summary changed from users constantly fail to recognice they are registeren to Users are redirected to the login screen with no confirmation email and fail to recognize they are registered

It should be fairly straightforward to use add_notice to display a message to the user and show they are registered.

comment:2 in reply to: ↑ 1 Changed 4 years ago by hasienda

  • Keywords trivial added
  • Severity changed from normal to critical
  • Summary changed from Users are redirected to the login screen with no confirmation email and fail to recognize they are registered to Users redirected to login screen with no confirmation may fail to recognize that they are registered
  • Type changed from defect to enhancement

Replying to rjollos:

It should be fairly straightforward to use add_notice to display a message to the user and show they are registered.

Right, but a patch is still needed. Only I'm just too tired to do it right now.

comment:3 Changed 4 years ago by hasienda

  • Keywords user register added
  • Summary changed from Users redirected to login screen with no confirmation may fail to recognize that they are registered to [patch] Users redirected to login screen with no confirmation may fail to recognize that they are registered

Good news: While stumbling through the code to debug another issue I spotted a nice place, where this could be hooked into.

I've a nice working solution now, almost trivial, but need to separate from other changes I've prepared in parallel. Patch will be attached later.

Changed 4 years ago by hasienda

Confirmation after successful registration of user «test» in Trac 0.12

comment:4 Changed 4 years ago by hasienda

See screen capture with fix applied to trunk.

This is already an heavily patched test application with i18n support and German translation in place as well. The English original message test would be

Registration has been finished successfully. You may login as user %(user)s now.

comment:5 Changed 4 years ago by hasienda

  • Resolution set to fixed
  • Status changed from new to closed

(In [9199]) AccountManagerPlugin: Add message to confirm successful registrations, closes #7576.

comment:6 follow-up: Changed 23 months ago by stoecker

  • Resolution fixed deleted
  • Status changed from closed to reopened

Does not work. See e.g. JOSM Trac which runs 0.4.

comment:7 Changed 23 months ago by hasienda

Indeed, I noticed that too, but only with older Trac version. Nevertheless I see, that JOSM Trac runs on current stable Trac-1.0 (what was not around at the time of the last change to this ticket). Will re-check.

So far I know, that its an issue with Trac 0.11, that has, but doesn't use Chrome.add_notice correctly. There are many more occasions, when Trac-0.12 and later will show a message box, while earlier versions wont.

I refrained from fixing it everywhere on purpose: "works-with-0.12" doesn't break functionality but mildly encourages to upgrade to a more recent Trac version, if someone had a big issue with that.

So you want me to duplicate functionality at least for this occasion? Will do, but mainly because this feature has been requested for 0.11 initially.

comment:8 in reply to: ↑ 6 Changed 23 months ago by hasienda

Replying to stoecker:

Does not work. See e.g. JOSM Trac which runs 0.4.

Hm, did tests with Trac 0.11, 1.0 and 1.1dev, but only 0.11 failed to show the success messages.

So do we need to find the issue within JOSM Trac config?

And I'm thinking hard, how to push the success message to the login page for Trac 0.11, because existing workaround relies on rendering messages from the data dict. I fear, that the redirect to /login complicates passing the message a lot, because before the redirect neither the future Request object nor the data dict for templates/login.html are available. Until now only one the (anonymous) user session (something like req.session['chrome_message']) came to my mind.

comment:9 Changed 21 months ago by hasienda

  • Owner changed from pacopablo to hasienda
  • Status changed from reopened to new

comment:10 Changed 20 months ago by rjollos

  • Keywords needinfo added

I'd vote for not worrying about this issue on Trac 0.11, unless someone insists loudly and provides a strong case for why they can't upgrade. As mentioned, the concerning issue seems to be that this should work fine with JOSM Trac, so it seems we need more info.

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.