Ticket #7723 (closed defect: invalid)

Opened 3 years ago

Last modified 7 months ago

Trac users with permission TICKET_ADD_HOURS can't change his hours

Reported by: m.maak@dotsource.de Assigned to: rjollos
Priority: normal Component: TracHoursPlugin
Severity: normal Keywords: permission problem
Cc: stefano.cailotto@edalab.it Trac Release: 0.12

Description

A normal trac user with the right permission (TICKET_ADD_HOURS) can't change his hours. Only a user with the permission "TRAC_ADMIN" can change it.

Attachments

Change History

10/19/10 16:36:05 changed by anonymous

  • release changed from 0.11 to 0.12.

11/29/10 09:40:46 changed by rjollos

  • owner changed from k0s to rjollos.

This is working fine for me. In testing it out, I also granted TICKET_MODIFY permission to anonymous, and was able to add hours to a ticket. Can you provide any other details? What other permissions have you granted to the user that isn't able to change their hours?

11/29/10 16:22:00 changed by m.maak@dotsource.de

The following permissions i have granted to the user that isn't able to change their hours. 

BROWSER_VIEW
CHANGESET_VIEW
FILE_VIEW
LOG_VIEW
MILESTONE_VIEW
REPORT_SQL_VIEW
REPORT_VIEW
ROADMAP_VIEW
SEARCH_VIEW
TICKET_ADD_HOURS
TICKET_CREATE
TICKET_EDIT_CC
TICKET_EDIT_COMMENT
TICKET_EDIT_DESCRIPTION
TICKET_MODIFY
TICKET_VIEW
TIMELINE_VIEW
WIKI_CREATE
WIKI_MODIFY
WIKI_VIEW

(follow-up: ↓ 6 ) 11/29/10 16:26:23 changed by m.maak@dotsource.de

User can add hours, but the user can't change or remove it!

(in reply to: ↑ 5 ) 11/29/10 16:29:09 changed by rjollos

  • status changed from new to assigned.

Replying to m.maak@dotsource.de:

User can add hours, but the user can't change or remove it!

Ahh, okay. I was just about to ask about that. I'll do some additional testing later today and get back to you.

12/04/10 01:31:57 changed by rjollos

I can't reproduce with the lastest version of TracHoursPlugin. I fixed up some permission check today, but can't immediately think of how those changes might have resolved this issue.

Could you please test again with the latest version of TracHoursPlugin?

12/06/10 23:17:35 changed by rjollos

  • status changed from assigned to closed.
  • resolution set to worksforme.

I've tested with Trac 0.12.2dev-r10331 and r9606 of branches/0.12 and can't reproduce the issue. I suspect it has been fixed in the time since you reported it. Please reopen if you continue to see the problem after upgrading.

10/11/12 21:13:04 changed by rjollos

  • status changed from closed to reopened.
  • cc set to stefano.cailotto@edalab.it.
  • resolution deleted.

Posting on behalf of Stefano Cailotto:

Hello, I've more or less the same problem... even as TRAC_ADMIN (TICKET_ADD_HOURS), I can only add hours but I can't remove them. I'm using trac 0.12.4 (tar archive from edgewall site).

10/11/12 21:18:20 changed by rjollos

  • status changed from reopened to new.

10/11/12 21:25:38 changed by rjollos

  • status changed from new to assigned.

(follow-up: ↓ 13 ) 10/19/12 00:59:14 changed by rjollos

Hi Stefano, I haven't been able to reproduce. What happens when you try to remove hours while on the /hours/id page? Which database are you using?: SQLite, MySQL, or PostgreSQL?

(in reply to: ↑ 12 ; follow-up: ↓ 14 ) 10/19/12 10:10:36 changed by kai

  • status changed from assigned to closed.
  • resolution set to invalid.

Replying to rjollos:

Hi Stefano, I haven't been able to reproduce. What happens when you try to remove hours while on the /hours/id page? Which database are you using?: SQLite, MySQL, or PostgreSQL?

Hi Ryan, I updated the plugin to the last revision (I was using 0.6.0dev-r12031) and now I can see the "apply changes" button under hours list for the ticket, so I consider the problem was mine. Thanks for your help!

(in reply to: ↑ 13 ; follow-up: ↓ 15 ) 10/19/12 10:12:52 changed by rjollos

Replying to kai:

Hi Ryan, I updated the plugin to the last revision (I was using 0.6.0dev-r12031) and now I can see the "apply changes" button under hours list for the ticket, so I consider the problem was mine.

There were some recent changes with the plugin, but I can't say specifically what could have fixed your issue. Please don't hesitate to raise another ticket if you find other problems. I think the code needs a bit of work, but this plugin is a priority for me, and I appreciate the feedback and testing.

(in reply to: ↑ 14 ; follow-up: ↓ 16 ) 10/19/12 17:07:22 changed by anonymous

Replying to rjollos:

Replying to kai:

Hi Ryan, I updated the plugin to the last revision (I was using 0.6.0dev-r12031) and now I can see the "apply changes" button under hours list for the ticket, so I consider the problem was mine.

There were some recent changes with the plugin, but I can't say specifically what could have fixed your issue. Please don't hesitate to raise another ticket if you find other problems. I think the code needs a bit of work, but this plugin is a priority for me, and I appreciate the feedback and testing.

It happened that once the button "disappeared" again, especially with Chrome, but I guess it's due to caching...

One thing that I noticed is that total hours count is not reported as time units, i.e 1:15 hour + 12:30 hours is reported as 13.8 hours, while it should be imho 13:45 h.

This would be very useful to be used as a sort of timesheet. Also the capability to export a report in xls/csv would be very appreciated.

Thank you, S.

(in reply to: ↑ 15 ) 10/27/12 00:41:17 changed by rjollos

Replying to anonymous:

One thing that I noticed is that total hours count is not reported as time units, i.e 1:15 hour + 12:30 hours is reported as 13.8 hours, while it should be imho 13:45 h.

=> #10554.

This would be very useful to be used as a sort of timesheet. Also the capability to export a report in xls/csv would be very appreciated.

=> #10553.

Add/Change #7723 (Trac users with permission TICKET_ADD_HOURS can't change his hours)




Change Properties
Action