Opened 3 years ago
Last modified 3 years ago
Neither SubticketsPlugin nor MasterTicketsPlugin use a "#" in the database value, only on display. This patch makes ChildTicketsPlugin consistent with those. It also makes it possible to import ChildTicketsPlugin parents with the TicketImportPlugin.
Remove # from values in db
Hi Chris
The decision to use a '#' in the ticket-custom field was a deliberate one. Prior to trac 0.11(.3 - I think??), in my old firm I did indeed use something similar to the 'linkify' code used in MasterTicketsPlugin. By using the 'parent.type=wiki' setting in the ticket-custom field (available since 0.11), trac will take care of the whole 'linkifying' business and ensure future trac versions remain compatible.
From the point of view of the user it should make little difference as the idea is generally that the child ticket is created from the parent ticket directly using the 'create child' button (MasterTicketsPlugin operates vice-versa) and so the user should never have to actually enter a parent ticket number anyway.
It reduces significantly the code that needs to be maintained in this plugin (ie. the whole 'linkify' code you include in the #7840 patch is not needed).
I have no idea how many people are using this plugin (a few I would guess as I have had several comments asking me to continue support for it) but to implement this patch now would also break any existing ticket relationships they have already in their db. (ie. Existing '#n' values trip up when the plugin tries to treat these values directly as integers).
So.... unless a lot of people come forward and say this is something that is really required I would rather not implement these (#7839 and #7840) patches and will leave it to trac to manage the 'linkify' step on behalf of the plugin. Keep It Simple and all that... :-)
Thanks for the input/ideas and I'd like to know if there are any other compatibility issues with other plugins (ie. exactly how are people using the plugin!)
Thx Mark
