Modify

Opened 8 years ago

Closed 7 years ago

#795 closed defect (fixed)

AddComment does not post, preview, or cancel.

Reported by: aaron@… Owned by: athomas
Priority: high Component: AddCommentMacro
Severity: normal Keywords:
Cc: Stephan.Wacker@…, blach@…, nick-trachacks@…, robert@… Trac Release: 0.10

Description

When I click Add Comment, Preview, or Cancel, it attempts to load, e.g. /wiki/MyWikiPage#commentpreview and there is simply a "Create this page" button, nothing else.

I've just upgraded to 0.10.1dev; if it is a configuration issue, no such indications were given on the hack's description page.

Attachments (0)

Change History (14)

comment:1 Changed 8 years ago by jose.junior@…

  • Priority changed from normal to high

Same behavior here using 0.10.

comment:2 Changed 8 years ago by athomas

  • Resolution set to worksforme
  • Status changed from new to closed

Works for me using 0.10.3. This could have been an artifact of the CSRF protection.

comment:3 follow-up: Changed 8 years ago by harald

  • Resolution worksforme deleted
  • Status changed from closed to reopened

would have been nice but still doesn't work for me

see http://harald.fluffnstuff.org/wiki/test

comment:4 in reply to: ↑ 3 Changed 8 years ago by coderanger

Replying to harald:

would have been nice but still doesn't work for me

see http://harald.fluffnstuff.org/wiki/test

Did you modify the macro at all? It seems to be using POSTs where it should be using GETs.

comment:5 Changed 8 years ago by harald

egbert:/home/harald/trac-stuff/addcommentmacro/0.10# svn up
At revision 1851.
egbert:/home/harald/trac-stuff/addcommentmacro/0.10# svn status
? build
? TracAddCommentMacro.egg-info
? temp

therefore no :)

I'm running trac on an apache webserver using mod_python, could this somehow interfere?

comment:6 Changed 8 years ago by eric@…

  • Trac Release changed from 0.9 to 0.10

Yes, the code in svn (as of r1855) is using 'post'
as the method.

Changing the method='post' to method='get' has solved
the problem for me. (on 0.10.3)

comment:7 Changed 8 years ago by harald

Verified. Changing the method from post to get worked for me too.

comment:8 follow-up: Changed 8 years ago by paul@…

Switching from post to get might fix the code, but it is definitely not an appropriate use of HTTP GET.

http://www.w3.org/2001/tag/doc/whenToUseGet.html

comment:9 in reply to: ↑ 8 Changed 8 years ago by eric@…

Replying to paul@prescod.net:

Switching from post to get might fix the code, but it is definitely not an
appropriate use of HTTP GET.

Agreed. People can (and do) reload a page and double post a comment.
Does anybody have a better fix yet? Thanks.

comment:10 Changed 7 years ago by anonymous

  • Cc Stephan.Wacker@… added

comment:11 Changed 7 years ago by anonymous

  • Cc blach@… added

comment:12 Changed 7 years ago by anonymous

  • Cc nick-trachacks@… added

comment:13 Changed 7 years ago by anonymous

  • Cc robert@… added

comment:14 Changed 7 years ago by coderanger

  • Resolution set to fixed
  • Status changed from reopened to closed

Please upgrade to the latest version. This should pull in the MacroPostPlugin, which will fix the issue.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from athomas. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.