Ticket #7976 (new defect)

Opened 3 years ago

Last modified 6 months ago

filter_exception_realms is ignored in DefaultPermissionFilter

Reported by: anonymous Assigned to: hasienda
Priority: normal Component: AnnouncerPlugin
Severity: major Keywords: acct_mgr permission
Cc: rjollos, doki_pen Trac Release: 0.12

Description

This makes it impossible for the acct_mgr plugin to ever work.

Attachments

Change History

11/03/10 01:36:56 changed by anonymous

Change if permsys.check_permission(action, sid): to if event.realm in self.exception_realms or permsys.check_permission(action, sid):.

11/09/10 18:38:32 changed by doki_pen

  • priority changed from normal to highest.

Thanks, I'll try and get to this soon.

10/21/12 13:52:36 changed by hasienda

  • keywords set to acct_mgr permission.
  • owner changed from doki_pen to hasienda.
  • severity changed from critical to major.
  • cc set to rjollos, doki_pen.
  • priority changed from highest to normal.

I understand, that this is related to a permission check.

But without more explanation I'm reluctant to apply this blindly right-away. I'd rather take a breath and resolve it in concert with related issues, notably #7759, #7974 and #7977.

11/08/12 00:57:22 changed by hasienda

(In [12309]) TracAnnouncer: Implement unused filter_exception_realms option, refs #7976 and #7977.

The chosen implementation should be slightly more efficient than what has been proposed in #7976, but I agree, that this is a pre-reqisite for making some subscribers effective, i.e. AccountManagerPlugin notifications.

11/09/12 01:17:52 changed by hasienda

(In [12325]) TracAnnouncer: Fix generator, that was broken by [12309], refs #7759, #7976, #7977, #8740, #8927, #9090 and #9204.

And the same bad filter code even got replicated in [12312]. Sorry for not checking compiler errors earlier. Finally I discovered an UnboundLocalError for resource_id hidden behind the first error. Obviously unit tests are a blessing and needed here too.

11/09/12 23:38:00 changed by hasienda

(In [12331]) TracAnnouncer: Really fix filter now, refs #7759, #7976, #7977, #8740, #8927, #9090 and #9204.

Complete the change from [12325] to get expected behavior, or filters would be applied undesirably.

11/11/12 23:36:11 changed by hasienda

(In [12342]) TracAnnouncer: Add 'acct_mgr' as default for 'filter_exception_realms' option, refs #7759, #7976, #7977, #8740, #8927, #9090 and #9204.

IMHO this is required for better plugin usability, making AccountManagerPlugin notifications pass without additional configuration effort now.

Some Python doc-string tweaks and another unit test slipped in here too.

11/15/12 01:13:44 changed by rjollos

(In [12353]) Refs #7759, #7976, #7977, #8740, #8927, #9090 and #9204: Fixed minor syntax error introduced in [12342].

Add/Change #7976 (filter_exception_realms is ignored in DefaultPermissionFilter)




Change Properties
Action