Ticket #8005 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

[patch] get_htdocs_dirs() method should return a unique prefix

Reported by: jun66j5 Assigned to: hasienda
Priority: low Component: DataSaverPlugin
Severity: normal Keywords: i18n
Cc: Trac Release: 0.12

Description

DataSaverModule.get_htdocs_dirs returns 'htdocs' as prefix. The 'htdocs' is a very common word.

I think that DataSaverPlugin should use datasaver. datasaver-prefix.diff

Attachments

datasaver-prefix.diff (1.0 kB) - added by jun66j5 on 11/09/10 12:45:27.

Change History

11/09/10 12:45:27 changed by jun66j5

  • attachment datasaver-prefix.diff added.

(in reply to: ↑ description ) 11/09/10 20:14:44 changed by hasienda

  • status changed from new to assigned.
  • keywords set to i18n.
  • summary changed from DataSaverModule.get_htdocs_dirs should return a unique prefix to [patch] get_htdocs_dirs() method should return a unique prefix.

Replying to jun66j5:

[...] I think that DataSaverPlugin should use datasaver. datasaver-prefix.diff

I think this too, as this is a universal rule, not only for DataSaverPlugin.

Thanks for catching this as is was certainly done by me by mistake. Must have been to busy looking for the special JS i18n implementation details for this plugin, so overlooked this.

No harm done by now, but if more plugins would resort to the unintended «htdocs» namespace, this could cause nasty effects. I'll fix it right away, before someone else copies this for his/her own plugin.

11/09/10 21:29:56 changed by hasienda

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [9406]) DataSaverPlugin: Correct indesired i18n namespace, closes #8005.

Thanks to Jun Omae for finding this and suggesting the solution right away.

Add/Change #8005 ([patch] get_htdocs_dirs() method should return a unique prefix)




Change Properties
Action