Modify

Opened 4 years ago

Closed 4 years ago

#8005 closed defect (fixed)

[patch] get_htdocs_dirs() method should return a unique prefix

Reported by: jun66j5 Owned by: hasienda
Priority: low Component: DataSaverPlugin
Severity: normal Keywords: i18n
Cc: Trac Release: 0.12

Description

DataSaverModule.get_htdocs_dirs returns 'htdocs' as prefix. The 'htdocs' is a very common word.

I think that DataSaverPlugin should use datasaver. datasaver-prefix.diff

Attachments (1)

datasaver-prefix.diff (1.0 KB) - added by jun66j5 4 years ago.

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by jun66j5

comment:1 in reply to: ↑ description Changed 4 years ago by hasienda

  • Keywords i18n added
  • Status changed from new to assigned
  • Summary changed from DataSaverModule.get_htdocs_dirs should return a unique prefix to [patch] get_htdocs_dirs() method should return a unique prefix

Replying to jun66j5:

![...]
I think that DataSaverPlugin should use datasaver. datasaver-prefix.diff

I think this too, as this is a universal rule, not only for DataSaverPlugin.

Thanks for catching this as is was certainly done by me by mistake. Must have been to busy looking for the special JS i18n implementation details for this plugin, so overlooked this.

No harm done by now, but if more plugins would resort to the unintended «htdocs» namespace, this could cause nasty effects. I'll fix it right away, before someone else copies this for his/her own plugin.

comment:2 Changed 4 years ago by hasienda

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [9406]) DataSaverPlugin: Correct indesired i18n namespace, closes #8005.

Thanks to Jun Omae for finding this and suggesting the solution right away.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.