Modify

Opened 4 years ago

Closed 4 months ago

Last modified 4 months ago

#8030 closed enhancement (wontfix)

support batch edit on the report page (in addition to query page)

Reported by: liucougar Owned by: CuriousCurmudgeon
Priority: normal Component: BatchModifyPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

currently BatchModifyPlugin only works on query page. most buildin reports use sql, and are handled by report module, instead of query, so this batch modify feature is not available in any sql based report

I am working on a patch to fix this

Attachments (1)

8030.patch (5.3 KB) - added by liucougar 4 years ago.
latest patch to get rid of site.html

Download all attachments as: .zip

Change History (8)

comment:1 Changed 4 years ago by liucougar

I received the following error while trying to upload my patch:

500 Internal Server Error (Submission rejected as potential spam (Maximum number of external links per post exceeded, Content contained these blacklisted patterns: '(?i)style\s*=\s*(["']).*?(?:width|height).*\b(?:0|1)\s*px.*?(?:\1)', '(?i)<a href='))

I will upload it to my server, and give a link instead

comment:2 Changed 4 years ago by liucougar

the patch is against http://trac-hacks.org/svn/batchmodifyplugin/0.12/trunk

the new file batchmod/templates/report_view.html is basically a copy of the same file shipped with trac-0.12.1, with a single modification:

<th py:for="header in header_group" py:if="not header.hidden" py:with="fullrow = header is header_group[-1]"
                     colspan="${fullrow and '100' or None}" class="${' '.join([x for x in [header.asc is not None and ('desc', 'asc')[header.asc] or None, header.col] if x is not None])}">

basically this modification adds class to <th> element in report result page so that batchmode.js can add a checkbox to the <thead> at the correct place (I choose to add the whole file so a user of batchmodifyplugin can just copy it to their TRAC_ENV_DIR/templates to overwrite the default one)

let me know what do you think

comment:3 Changed 4 years ago by anonymous

a new patch is up, still at http://trac-hacks.org/svn/batchmodifyplugin/0.12/trunk

this one replaces batchmod/templates/report_view.html with batchmod/templates/site.html, which should be copied to the user's TRAC_ENV/templates/ (or merged with existing site.html file)

I don't know how to modify report_view.html without asking user to copy the site.html into TRAC_ENV

comment:4 Changed 4 years ago by CuriousCurmudgeon

  • Status changed from new to assigned

Sorry for the slow response. Look at the ITemplateStreamFilter interface. You can see it is already implemented in web_ui.py. You can use it to intercept a response stream and modify it however you need. This is how information is added the query page. This prevents needed to copy anything to TRAC_ENV/templates/. Just add another case on their to intercept the report page and you can modify it however you want.

Try attaching it as a patch again as well. Sometimes Trac-Hacks has problems with spam so the filter starts rejecting valid files.

comment:5 Changed 4 years ago by liucougar

updated the patch to remove site.html: do everything in filter_stream function

Changed 4 years ago by liucougar

latest patch to get rid of site.html

comment:6 Changed 4 months ago by rjollos

  • Resolution set to wontfix
  • Status changed from assigned to closed

The plugin is deprecated since it has been integrated to the Trac core for 1.0. Upgrade to Trac 1.0 and uninstall this plugin to get the latest functionality. Enhancement requests can be directed to Trac.

comment:7 Changed 4 months ago by rjollos

Additional comment in trac:comment:8:ticket:8219.

Add Comment

Modify Ticket

Action
as closed The owner will remain CuriousCurmudgeon.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.