Modify

Opened 4 years ago

Closed 2 years ago

#8286 closed defect (fixed)

Make proper use of the Trac database API

Reported by: rjollos Owned by: rjollos
Priority: high Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: olemis Trac Release: 0.11

Description

The dbEscape function is entirely unnecessary with proper use of the Trac DB API. All of the queries in this plugin need to be rewritten. See t:TracDev/DatabaseApi for more information.

Attachments (0)

Change History (6)

comment:1 Changed 4 years ago by rjollos

  • Owner changed from proofek to rjollos
  • Status changed from new to assigned

comment:2 Changed 4 years ago by rjollos

  • Priority changed from normal to high

comment:3 Changed 3 years ago by andersm

  • Owner changed from rjollos to andersm
  • Status changed from assigned to new

comment:4 Changed 2 years ago by rjollos

  • Owner changed from andersm to rjollos
  • Type changed from task to defect

comment:5 Changed 2 years ago by rjollos

  • Cc olemis added; anonymous removed
  • Status changed from new to assigned

The 2.2dev branch was moved to the trunk in [11987], and this issue was mostly fixed in the 2.2dev branch. I'll follow with a small commit.

comment:6 Changed 2 years ago by rjollos

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [12477]) Fixes #8286:

  • Removed obsolete dbEscape function and unnecessary imports.
  • Formatted some SQL statements per Trac guidelines (1).

(1) trac:TracDev/DatabaseApi#GuidelinesforSQLStatements

Add Comment

Modify Ticket

Action
as closed The owner will remain rjollos.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.