Ticket #8299 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

parentheses in milestone name confuse plugin macros, they show empty content then

Reported by: falkb Assigned to: osimons
Priority: normal Component: EstimationToolsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description (Last modified by rjollos)

Give a milestone this name: 

S2-DX2 - N3 (test)

Then 

[[BurndownChart(milestone=S2-DX2 - N3 (test), startdate=2010-06-11)]]

[[WorkloadChart(milestone=S2-DX2 - N3 (test))]]

remain empty, and 

[[HoursRemaining(milestone=S2-DX2 - N3 (test))]]

displays just 0 although I have some tickets for that milestone with remaining hours set.

If I do not use parentheses in the milestone name, everything works well. Spaces in the name are not a problem.

(seen with Bitnami Trac 0.12.1, Native on Windows), EstimationTools-0.4.5-py2.5.egg

Attachments

t8299-query_paranthesis-r10557.diff (2.3 kB) - added by osimons on 08/25/11 13:26:22.
Unquote parenthesis in query.

Change History

12/13/10 11:57:36 changed by rjollos

  • description changed.

05/10/11 06:54:03 changed by AdrianFritz

Reproduced. Trac 0.12 on Linux. Tested also with only ( or ).

(follow-up: ↓ 5 ) 05/10/11 15:09:39 changed by anonymous

Test details - Error messages

MIlestone Contains WorkloadChart BurndownChart HoursRemaining
"2011-05 (test)" both ( & ) blank blank 0
"(2011-05 test" leading ( blank blank 0
"2011-05 (test" intermediate ( blank blank 0
"2011-05 test)" trailing ) blank blank 0

Looks like the issue is in _calculate_timetable (@ http://trac-hacks.org/browser/estimationtoolsplugin/trunk/estimationtools/burndownchart.py?rev=10082#L144)

05/10/11 15:14:17 changed by AdrianFritz

sorry, forgot to login

Just a note for my-self: @http://trac-hacks.org/browser/estimationtoolsplugin/trunk/estimationtools/burndownchart.py?rev=10082#L13:

  • from: 'bgcolor': 'ffffff00', 'wecolor':'ccccccaa', 'colorexpected': 'ffddaa', 'weekends':'true', 'gridlines' : '0'}
  • to: 'bgcolor': 'ffffff', 'wecolor':'cccccc', 'colorexpected': 'ffddaa', 'weekends':'true', 'gridlines' : '0'}

(in reply to: ↑ 3 ) 05/10/11 15:20:01 changed by falkb

Replying to anonymous:

Looks like the issue is in _calculate_timetable (@ http://trac-hacks.org/browser/estimationtoolsplugin/trunk/estimationtools/burndownchart.py?rev=10082#L144)

Maybe http://trac-hacks.org/browser/estimationtoolsplugin/trunk/estimationtools/utils.py#L131 must simply consider "(" and ")" as well. At least it's called by _calculate_timetable

08/25/11 13:26:22 changed by osimons

  • attachment t8299-query_paranthesis-r10557.diff added.

Unquote parenthesis in query.

(follow-up: ↓ 7 ) 08/25/11 13:27:54 changed by osimons

Replying to falkb:

Maybe estimationtoolsplugin/trunk/estimationtools/utils.py#L131 must simply consider "(" and ")" as well. At least it's called by _calculate_timetable

That looks to be the correct solution, but please test attachment:t8299-query_paranthesis-r10557.diff

(in reply to: ↑ 6 ) 08/25/11 13:52:23 changed by anonymous

Replying to osimons:

That looks to be the correct solution, but please test attachment:t8299-query_paranthesis-r10557.diff

Patch works well! Fixed. Thanks very much. :-)

08/25/11 14:06:06 changed by osimons

  • status changed from new to closed.
  • resolution set to fixed.

(In [10617]) EstimationToolsPlugin: Milestone names with '(' or ')' in them display no data. Need to unquote parenthesis for query arguments. Closes #8299.

Add/Change #8299 (parentheses in milestone name confuse plugin macros, they show empty content then)




Change Properties
Action