Ticket #8426 (closed enhancement: wontfix)

Opened 2 years ago

Last modified 2 years ago

Allow rating on Reports

Reported by: rlrj60 Assigned to: rjollos
Priority: high Component: FiveStarVotePlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Many people in my work group have spent lots of time to create fancy reports with charts. It would be nice to have the same rating. Here's a simple patch: 

voteable_paths = ListOption('fivestarvote', 'paths', '^/$,^/wiki*,^/ticket*,^/report*',

Attachments

Change History

(follow-up: ↓ 2 ) 01/20/11 20:53:16 changed by rjollos

  • priority changed from normal to high.
  • status changed from new to assigned.

We have a couple of considerations here in maintaining this plugin:

  • preserve existing behavior when possible so users are not surprised by an upgrade.
  • make the default behavior applicable to the majority of the installations.

You always have the option of specifying in trac.ini: 

paths  = ^/$,^/wiki*,^/ticket*,^/report*

to configure for your specific Trac installation.

Whether or not we make the change to the option's default really comes down to the question: would the majority of users want voting on reports?

Let me know your thoughts.

(in reply to: ↑ 1 ; follow-up: ↓ 3 ) 01/21/11 17:28:24 changed by rlrj60

Replying to rjollos:

You always have the option of specifying in trac.ini: paths = ^/$,^/wiki*,^/ticket*,^/report* to configure for your specific Trac installation.

I stared at the code several times but missed the "path" option. Looks like the capability is there for me. There is no need to add to the code.

Thanks for pointing that out.

(in reply to: ↑ 2 ) 01/22/11 09:00:05 changed by rjollos

  • status changed from assigned to closed.
  • resolution set to wontfix.

Replying to rlrj60:

I stared at the code several times but missed the "path" option. Looks like the capability is there for me. There is no need to add to the code.

I'm glad to hear that works for you.

This ticket brings up a good point though, that the path option should be documented on the project wiki page, which I will do now.

01/22/11 09:13:19 changed by rjollos

Updated project wiki page: changes.

Add/Change #8426 (Allow rating on Reports)




Change Properties
Action