Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#8426 closed enhancement (wontfix)

Allow rating on Reports

Reported by: rlrj60 Owned by: rjollos
Priority: high Component: FiveStarVotePlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Many people in my work group have spent lots of time to create fancy reports with charts. It would be nice to have the same rating. Here's a simple patch:

voteable_paths = ListOption('fivestarvote', 'paths', '^/$,^/wiki*,^/ticket*,^/report*', 

Attachments (0)

Change History (4)

comment:1 follow-up: Changed 4 years ago by rjollos

  • Priority changed from normal to high
  • Status changed from new to assigned

We have a couple of considerations here in maintaining this plugin:

  • preserve existing behavior when possible so users are not surprised by an upgrade.
  • make the default behavior applicable to the majority of the installations.

You always have the option of specifying in trac.ini:

paths  = ^/$,^/wiki*,^/ticket*,^/report*

to configure for your specific Trac installation.

Whether or not we make the change to the option's default really comes down to the question: would the majority of users want voting on reports?

Let me know your thoughts.

comment:2 in reply to: ↑ 1 ; follow-up: Changed 4 years ago by rlrj60

Replying to rjollos:

You always have the option of specifying in trac.ini:
paths = ^/$,^/wiki*,^/ticket*,^/report*
to configure for your specific Trac installation.

I stared at the code several times but missed the "path" option. Looks like the capability is there for me. There is no need to add to the code.

Thanks for pointing that out.

comment:3 in reply to: ↑ 2 Changed 4 years ago by rjollos

  • Resolution set to wontfix
  • Status changed from assigned to closed

Replying to rlrj60:

I stared at the code several times but missed the "path" option. Looks like the capability is there for me. There is no need to add to the code.

I'm glad to hear that works for you.

This ticket brings up a good point though, that the path option should be documented on the project wiki page, which I will do now.

comment:4 Changed 4 years ago by rjollos

Updated project wiki page: changes.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.