Modify

Opened 3 years ago

Last modified 22 months ago

#8620 new defect

[Patch] Small grammatical fix in the ticket_email_mimic.html email

Reported by: jc2trachacks Owned by: hasienda
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords:
Cc: rjollos, doki_pen Trac Release: 0.12

Description (last modified by rjollos)

I have a picky user that complained about this line in the html email:

  • Resolution changed from [shouldn't something be here?] to Fixed.

The old resolution was simply a <blank> value. Thus the patch simply checks for a value before printing the preceding "from".

Now, if the old resolution has no value, it becomes:

  • Resolution changed to Fixed.

Attachments (1)

patch.diff (943 bytes) - added by jc2trachacks 3 years ago.

Download all attachments as: .zip

Change History (4)

Changed 3 years ago by jc2trachacks

comment:1 Changed 3 years ago by rjollos

  • Description modified (diff)
  • Summary changed from Small grammatical fix in the ticket_email_mimic.html email to [Patch] Small grammatical fix in the ticket_email_mimic.html email

comment:2 Changed 22 months ago by hasienda

(In [12345]) TracAnnouncer: Improve ticket change notification template, refs #8620.

Feels like there must be more corner-cases, that are not handled optimal now,
but this is an easy win, so won't miss it for older announcer versions as well.

Thanks to jc2trachacks for taking care to report as well as for providing a
good starting point towards the actual fix (omit the empty old value too).

comment:3 Changed 22 months ago by hasienda

  • Cc rjollos doki_pen added
  • Owner changed from doki_pen to hasienda

Couldn't resist to do that change, especially for such a remarkable change number.

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.