Modify

Opened 3 years ago

Last modified 20 months ago

#9692 assigned enhancement

[Patch] Use multi-tag separator from KeywordSuggestPlugin when installed

Reported by: itamarost Owned by: hasienda
Priority: normal Component: TagsPlugin
Severity: normal Keywords: delimiter separator configuration
Cc: rjollos, osimons Trac Release: 0.11

Description

The KeywordSuggestPlugin has a multipleseparator configuration option that triggers the autocomplete and is used to split keywords.

The proposed enhancement (and attached patch) suggests that when the tags are loaded into the tags input field (when filtering wiki_edit) the multipleseparator value will be used to delimiter the tags.

This allows the autocomplete to work properly when the separator is not a whitespace (e.g. a comma).

Related to #8141.

Note that this doesn't change the ticket keywords field.

Attachments (1)

tagsplugin-9692-sep-from-keywordsuggest-v1.patch (994 bytes) - added by itamarost 3 years ago.
patch against tagsplugin trunk

Download all attachments as: .zip

Change History (10)

Changed 3 years ago by itamarost

patch against tagsplugin trunk

comment:1 Changed 3 years ago by hasienda

  • Keywords delimiter separator configuration added; patch removed
  • Status changed from new to assigned

Ideally the option should reside in the tags configuration section, as this would be the place you'd look for it intuitively.

But keywordsuggest has been first in using it, and I was thinking exactly the same when looking at comment 20 in #9061.

comment:2 follow-up: Changed 3 years ago by itamarost

Well, I guess if we're going for the ideal, the option should reside in the ticket configuration section, and be used also by Trac core for the keywords field.

The path of minimal conflict is the one with least backward-incompatible changes, which is what I suggested. It does not introduce a dependency on KeywordSuggestPlugin per se, since it has default value if the option is not present.

comment:3 in reply to: ↑ 2 ; follow-up: Changed 3 years ago by osimons

  • Cc osimons added

Replying to itamarost:

Well, I guess if we're going for the ideal, the option should reside in the ticket configuration section, and be used also by Trac core for the keywords field.

Agree. There should be a common way of splitting field information. Use the one in Trac or a minimal compat handler in plugin to support older versions if needed. It could be general Trac though, and not just tickets. I could use the same logic for splitting categories in FullBlogPlugin posts.

Personally I think it should be a bit more elaborate than a character in a config, be it whitespace or comma or combination thereof. It should use some heuristics to determine the the current practice for the field and reuse that for splitting and joining.

Ideally it should be managed without settings by just being 'intuitive', and doing the 'right thing™'. I would help get such a patch with split/join utility functions committed to Trac.

comment:4 in reply to: ↑ 3 ; follow-up: Changed 3 years ago by osimons

Replying to osimons:

Ideally it should be managed without settings by just being 'intuitive', and doing the 'right thing™'.

The reason being of course that a hidden setting is very confusing when working with different Trac projects - you should not need to know a config setting to edit fields correctly.

comment:5 in reply to: ↑ 4 Changed 3 years ago by hasienda

Replying to osimons:

Replying to osimons:

Ideally it should be managed without settings by just being 'intuitive', and doing the 'right thing™'.

The reason being of course that a hidden setting is very confusing when working with different Trac projects - you should not need to know a config setting to edit fields correctly.

I second the emphasis on usability, but do you suggest to operate like this on a single value base? Using different delimiter styles within one table column would be a real pain for any SQL query with multiple lines involved, if reasonable at all within certain performance constraints.

comment:6 follow-up: Changed 3 years ago by osimons

Well, SQL on multi-value fields is always going to be a pain no matter what. However, I do see your point and it would help if there was some normalization for storage (which of course none of the fields do today). My meaning was more that the we should accept common patterns and not settle on a single character.

Here is my current favorite:

>>> import re
>>> s = 'tag1, tag2,tag3 tag4, "tag 5", "tag,6", "tag\'7"'
>>> [p.strip(", \"'") for p in re.split("(,| |\\\".*?\\\"|'.*?')", s) if p.strip(", \"'")]
['tag1', 'tag2', 'tag3', 'tag4', 'tag 5', 'tag,6', "tag'7"]

It isn't easy this, but we should try to not confuse things even further.

comment:7 in reply to: ↑ 6 Changed 3 years ago by hasienda

Replying to osimons:

Well, SQL on multi-value fields is always going to be a pain no matter what.

I see. For tickets there's no hope to change this, before multiple values per field (see t:#918) get implemented in general, right? Maybe some split and merge logic is not perfect yet, but TagsPlugin itself can store multiple tags per resource in tags Trac db table, so there is no such limitation for tags in general.

However, I do see your point and it would help if there was some normalization for storage (which of course none of the fields do today).

In fact KeywordSuggestPlugin already did some sanitization in the past, and this is another thing I like about it very much. But indeed, nothing in Trac core. Nevertheless, we should reach for better standards in this respect. I mean, for date/time fields it's natural, to parse and accept only valid entries, why not for keywords/tags too?

My meaning was more that the we should accept common patterns and not settle on a single character.

Here is my current favorite:
...
It isn't easy this, but we should try to not confuse things even further.

I'm all for accepting every string and trying to pull out valid tag(s) with best available logic. As I see it, this is not the end of the comma as a delimiter in general, just for storage. In the same move we could (should?) resort to reformatting according to current delimiter settings just for display.

At least this is my understanding of your proposal. Do we already have an agreement on this? More comments welcome, especially regarding display and normalization of stored values.

comment:8 Changed 2 years ago by hasienda

#9061 suggests possibly unwanted tag list normalization by the new tag mass edit functionality. Just something to consider when preparing the solution here.

comment:9 Changed 20 months ago by hasienda

Yet another case, another objective to consider:

Oblio Leitch:
Well, in my [use] case, I'm applying the plugin to a very active ticket system - there are already thousands of tickets. When I apply TagPlugin, the cloud that's created has lots of useless tags being generated by the keywords field in the existing tickets. Tags like "-", "&", "7", "I", etc. Yes, the keywords field shouldn't be used as a description field (eg "Defect: P & I Calc Date (Dormant)"), however, going through and changing all the keywords would be time consuming. It would be helpful to simply change the delimiter to a comma.

citation from trac-users mailing-list

Add Comment

Modify Ticket

Action
as assigned .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.