Ticket #9732 (closed defect: fixed)

Opened 1 year ago

Last modified 7 months ago

Forum sort direction not working when set from config/trac.ini

Reported by: jcoffland Assigned to: Blackhex
Priority: normal Component: DiscussionPlugin
Severity: normal Keywords: forum sort direction
Cc: Trac Release: 0.11

Description (Last modified by rjollos)

I couldn't get my forums to sort correctly with the forum_sort option in the trac configuration file. I search around in the code and found the problem. The variable forum_sort_direction is not being used correctly in api.py. I've attached a patch.

Otherwise, great plugin. Thanks!

Attachments

discussionplugin_0.11_forum_sort_direction.patch (1.0 kB) - added by jcoffland on 01/27/12 01:17:34.
Very simple patch to fix bug

Change History

01/27/12 01:17:34 changed by jcoffland

  • attachment discussionplugin_0.11_forum_sort_direction.patch added.

Very simple patch to fix bug

01/27/12 09:10:26 changed by Blackhex

Thank you.

01/27/12 22:45:35 changed by jcoffland

No problem. Glad to be able to contribute something.

01/28/12 04:04:31 changed by rjollos

  • description changed.

10/10/12 21:51:20 changed by rjollos

  • status changed from new to closed.
  • resolution set to fixed.

(In [12143]) Fixes #9732: The forum_sort_direction and topic_sort_direction options were not being respected. Thanks to jcoffland for the initial patch.

(follow-up: ↓ 6 ) 10/10/12 21:51:36 changed by rjollos

If you are able, please upgrade to r12143 and report back your findings. Thanks.

(in reply to: ↑ 5 ) 11/02/12 12:09:25 changed by sdegrande

Replying to rjollos:

If you are able, please upgrade to r12143 and report back your findings. Thanks.

Works well. Thanks

Add/Change #9732 (Forum sort direction not working when set from config/trac.ini)




Change Properties
Action