Modify

Opened 3 years ago

Closed 23 months ago

Last modified 22 months ago

#9732 closed defect (fixed)

Forum sort direction not working when set from config/trac.ini

Reported by: jcoffland Owned by: Blackhex
Priority: normal Component: DiscussionPlugin
Severity: normal Keywords: forum sort direction
Cc: Trac Release: 0.11

Description (last modified by rjollos)

I couldn't get my forums to sort correctly with the forum_sort option in the trac configuration file. I search around in the code and found the problem. The variable forum_sort_direction is not being used correctly in api.py. I've attached a patch.

Otherwise, great plugin. Thanks!

Attachments (1)

discussionplugin_0.11_forum_sort_direction.patch (1011 bytes) - added by jcoffland 3 years ago.
Very simple patch to fix bug

Download all attachments as: .zip

Change History (7)

Changed 3 years ago by jcoffland

Very simple patch to fix bug

comment:1 Changed 3 years ago by Blackhex

Thank you.

comment:2 Changed 3 years ago by jcoffland

No problem. Glad to be able to contribute something.

comment:3 Changed 3 years ago by rjollos

  • Description modified (diff)

comment:4 Changed 23 months ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed

(In [12143]) Fixes #9732: The forum_sort_direction and topic_sort_direction options were not being respected. Thanks to jcoffland for the initial patch.

comment:5 follow-up: Changed 23 months ago by rjollos

If you are able, please upgrade to r12143 and report back your findings. Thanks.

comment:6 in reply to: ↑ 5 Changed 22 months ago by sdegrande

Replying to rjollos:

If you are able, please upgrade to r12143 and report back your findings. Thanks.

Works well. Thanks

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.