Ticket #9760 (closed enhancement: fixed)

Opened 1 year ago

Last modified 8 months ago

Add compatibility with Trac 0.11.0

Reported by: rjollos Assigned to: ChrisNelson
Priority: normal Component: TracJsGanttPlugin
Severity: normal Keywords:
Cc: hasienda Trac Release: 0.11

Description

The attached patch allows for installation with Trac 0.11.0. This is copied from hasienda's work in [11200]

Attachments

th9600-trac0.11.0-tracjsgantt0.9-r11182.patch (1.8 kB) - added by rjollos on 02/03/12 21:44:24.

Change History

02/03/12 21:44:24 changed by rjollos

  • attachment th9600-trac0.11.0-tracjsgantt0.9-r11182.patch added.

(in reply to: ↑ description ) 02/03/12 22:00:15 changed by anonymous

Replying to rjollos:

The attached patch allows for installation with Trac 0.11.0. This is copied from hasienda's work in [11200]

Cool. Thanks. I'll try to merge that this weekend.

(follow-up: ↓ 3 ) 10/02/12 19:40:38 changed by rjollos

Experience has taught me that adding an install_requires for Trac is not a good idea, so I suggest ignoring the part of the patch that effects setup.py.

#10405 closed as a duplicate. I'd be happy to commit the patch if you are okay with it.

(in reply to: ↑ 2 ; follow-up: ↓ 4 ) 10/02/12 19:49:24 changed by anonymous

Replying to rjollos:

Experience has taught me that adding an install_requires for Trac is not a good idea, so I suggest ignoring the part of the patch that effects setup.py. #10405 closed as a duplicate. I'd be happy to commit the patch if you are okay with it.

If it still applies cleanly, go for it.

(in reply to: ↑ 3 ) 10/02/12 19:50:04 changed by ChrisNelson

Replying to anonymous:

Replying to rjollos:

Experience has taught me that adding an install_requires for Trac is not a good idea, so I suggest ignoring the part of the patch that effects setup.py. #10405 closed as a duplicate. I'd be happy to commit the patch if you are okay with it.

If it still applies cleanly, go for it.

That was me. I forgot to log in.

10/02/12 20:51:43 changed by rjollos

  • status changed from new to closed.
  • resolution set to fixed.

(In [12096]) Fixes #9760, Refs #10405: Restore compatibility back to Trac 0.11 by adding a fallback for when trac.util.text.javascript_quote is not available (Trac < 0.11.3). Copied from hasienda's patch in [11200].

Beware of #9892 before jumping to the conclusion that the plugin doesn't work. The sample seems to be broken, but ordinary usage of the plugin seems to be okay.

Add/Change #9760 (Add compatibility with Trac 0.11.0)




Change Properties
Action