Ticket #10096 (closed enhancement: fixed)

Opened 1 year ago

Last modified 10 months ago

support permission handling

Reported by: falkb Assigned to: falkb
Priority: normal Component: SimpleMultiProjectPlugin
Severity: normal Keywords: planned
Cc: crossroad, thomasd, rjollos Trac Release: 0.11

Description

at least we need PROJECT_ADMIN to hide the project editor for normal users

Attachments

Change History

06/14/12 15:49:38 changed by falkb

(In [11641]) refs #10096: support PROJECT_ADMIN, check it in get_admin_panels() and render_admin_panel()

06/15/12 08:06:53 changed by anonymous

  • cc changed from crossroad,thomasd to crossroad, thomasd, rjollos.

Ryan, I hope this was the right way, though somehow I didn't find an example for has_permission()

(follow-up: ↓ 4 ) 06/15/12 08:27:08 changed by rjollos

It looks correct to me. Two minor comments:

  • I'm not sure that specifying the realm in req.perm('projects') has any effect, but I'm still trying to understand the consequences of specifying a realm / resource. If it does have an effect, you might similarly want to specify req.perm('projects').require('PROJECT_ADMIN') in place of req.perm.require('PROJECT_ADMIN').
  • You might want to allow the page label to be translated, as you've already done for the category label: 
yield ('projects', _('Manage Projects'), 'simplemultiproject', 'Projects')

-> 

yield ('projects', _('Manage Projects'), 'simplemultiproject', _('Projects'))

(in reply to: ↑ 3 ) 06/15/12 08:48:48 changed by falkb

  • status changed from new to assigned.

Replying to rjollos:

It looks correct to me. Two minor comments:

Thanks for checking :-)

(follow-up: ↓ 7 ) 06/25/12 11:11:37 changed by falkb

TODO: maybe also PROJECT_LIST is needed

07/05/12 22:39:52 changed by falkb

(In [11713]) Refs #10096: now users with PROJECT_SETTINGS_VIEW can read the project name lists, the project info and their component assignments on the Admin panel

(in reply to: ↑ 5 ) 07/05/12 22:54:34 changed by falkb

  • keywords changed from planned to planned testing.

Replying to falkb:

TODO: maybe also PROJECT_LIST is needed

PROJECT_SETTINGS_VIEW seemed to be more appropriate to what it does. All trials to change the project settings end up with PROJECT_ADMIN privileges are required to perform this operation with just PROJECT_SETTINGS_VIEW.

Before closing I set this ticket to testing state now.

07/15/12 00:37:36 changed by falkb

  • keywords changed from planned testing to planned.
  • status changed from assigned to closed.
  • resolution set to fixed.

Add/Change #10096 (support permission handling)




Change Properties
Action