Modify

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#10418 closed enhancement (fixed)

Don't add a comment

Reported by: fommil Owned by: bjornharrtell
Priority: normal Component: GridModifyPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description

Thanks for this great plugin!

I find the auto comments to be very intrusive. The following patch will disable them, but if you feel there is value in the comments I would recommend having an option (off by default) for adding the comments.

diff -r ec2c58e517b9 gridmodifyplugin/trunk/gridmod/web_ui.py
--- a/gridmodifyplugin/trunk/gridmod/web_ui.py	Sat Aug 11 22:09:49 2012 +0000
+++ b/gridmodifyplugin/trunk/gridmod/web_ui.py	Fri Sep 28 18:22:23 2012 +0100
@@ -97,7 +97,7 @@
                     #   * Rendering is handled differently in the report form
                     #   * TextAreas support Wiki formatting so would need to use the Wiki engine
 
-                ticket.save_changes(author=req.authname, comment='updated by gridmod plugin')
+                ticket.save_changes(author=req.authname)
 
                 try:
                     tn = TicketNotifyEmail(self.env)
diff -r ec2c58e517b9 renameuserplugin/0.12/setup.py

Attachments (0)

Change History (4)

comment:1 Changed 2 years ago by fommil

  • Type changed from defect to enhancement

comment:2 Changed 2 years ago by rjollos

Just wanted to ask if this plugin is still being maintained by bjornharrtell.

comment:3 Changed 2 years ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed

(In [12221]) Fixes #10418: The superfluous comment "updated by gridmod plugin" is no longer added when editing a ticket in the grid.

comment:4 Changed 2 years ago by rjollos

(In [12222]) Refs #10418: Trac 0.11 requires an argument for comment. The method signature is save_changes(self, author, comment, when=None, db=None, cnum=''). In Trac 0.12, the method signature is save_changes(self, author=None, comment=None, when=None, db=None, cnum='').

Add Comment

Modify Ticket

Action
as closed The owner will remain bjornharrtell.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.