Modify

Opened 22 months ago

Closed 15 months ago

Last modified 4 months ago

#10607 closed defect (fixed)

installing ChangeLogMacro from trunk forces Trac deployment to update

Reported by: anonymous Owned by: rjollos
Priority: normal Component: ChangeLogMacro
Severity: normal Keywords: setuptools
Cc: hasienda Trac Release: 0.12

Description

I was running Trac 0.12.2; I downloaded the zip file of ChangeLogMacro, ran python ./trunk/setup.py install to install the trunk version. While this completed successfully, it forced my entire Trac deployment to upgrade. (each project reported an error, and required trac-admin /proj upgrade to be run) This was unexpected and could cause problems for others.

Attachments (0)

Change History (8)

comment:1 Changed 22 months ago by rjollos

  • Keywords needinfo added
  • Status changed from new to assigned
  • Trac Release set to 0.12

Is the error text Environment needs upgrade? I don't see how ChangeLogMacro could be forcing an upgrade since it doesn't implement IEnvironmentUpgradeParticipant.

comment:2 Changed 22 months ago by anonymous

Unfortunately, I didn't record the error, and I can't reproduce it. Since it was on a production instance, I went ahead with the upgrade.

comment:3 Changed 22 months ago by rjollos

Okay, thanks for the info. I will try to reproduce the error and follow-up here in a bit.

comment:4 follow-up: Changed 15 months ago by rjollos

  • Cc hasienda added
  • Keywords setuptools added; needinfo removed

I think I see what the issue is now. This is yet another reason to avoid install_requires=['Trac >= X.Y'] in setup.py.

comment:5 Changed 15 months ago by rjollos

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13267:

Fixes #10607: Don't use install_requires to enforce a Trac version constraint, as it can inadvertently upgrade a user's installation.

comment:6 in reply to: ↑ 4 Changed 15 months ago by hasienda

Replying to rjollos:

I think I see what the issue is now. This is yet another reason to avoid install_requires=['Trac >= X.Y'] in setup.py.

Good catch.

comment:7 Changed 14 months ago by rjollos

In 13285:

Refs #10797: Code cleanup: PEP-0008 changes, removed unused imports including unused import of pisa in web_ui.py. Removed Trac from install_requires, as this has been shown to cause problems (see #10607).

comment:8 Changed 4 months ago by rjollos

In 13849:

0.2: web_context is only available since Trac 1.0, so enforce a minimum Trac version at runtime. Refs #8365, #10607.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.