Modify

Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#10634 closed defect (fixed)

Source has tabs and improper indentation

Reported by: rjollos Owned by: natewlew
Priority: normal Component: PrivateWikiPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

The source contains tabs and some improper indentation. I hope you don't mind if I push a fix for this now.

Attachments (0)

Change History (7)

comment:1 follow-up: Changed 20 months ago by rjollos

This plugin is completely broken as far as I can tell. I've had to make a dozen changes just to get it partially working. Is anyone actually using this?

comment:2 Changed 20 months ago by natewlew

It seems to working for me. I have been using it for quite some time.

comment:3 Changed 20 months ago by rjollos

I just can't get it to work at all without making pretty major changes. I'll push the tab-space fix, and then make a fork on github, setup some tests and stack up some patches.

comment:4 Changed 20 months ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed

(In [12369]) Fixes #10634: Converted tabs to spaces and fixed indentation.

comment:5 Changed 20 months ago by rjollos

(In [12370]) Refs #10634: Applied misc formatting changes (applied via PyDev autoformatting) to conform to PEP8.

comment:6 in reply to: ↑ 1 ; follow-up: Changed 20 months ago by psuter

Replying to rjollos:

This plugin is completely broken as far as I can tell. I've had to make a dozen changes just to get it partially working. Is anyone actually using this?

I'm not a heavy user and I haven't tested it much, but I've had it installed for some time and it seemed to do the job. What problems did you see?

comment:7 in reply to: ↑ 6 Changed 20 months ago by rjollos

Replying to psuter:

I'm not a heavy user and I haven't tested it much, but I've had it installed for some time and it seemed to do the job. What problems did you see?

I made a few comments over in #10635. The first issue I had was due to not reading the documentation well enough, but there is also a more subtle problem having to do with not performing fine-grained checks for WIKI_CREATE. I plan to fix that issue and clean up some of the code in #10635.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from natewlew. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.