Ticket #10634 (closed defect: fixed)

Opened 6 months ago

Last modified 6 months ago

Source has tabs and improper indentation

Reported by: rjollos Assigned to: natewlew
Priority: normal Component: PrivateWikiPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

The source contains tabs and some improper indentation. I hope you don't mind if I push a fix for this now.

Attachments

Change History

(follow-up: ↓ 6 ) 11/18/12 02:56:14 changed by rjollos

This plugin is completely broken as far as I can tell. I've had to make a dozen changes just to get it partially working. Is anyone actually using this?

11/18/12 05:18:28 changed by natewlew

It seems to working for me. I have been using it for quite some time.

11/18/12 06:54:52 changed by rjollos

I just can't get it to work at all without making pretty major changes. I'll push the tab-space fix, and then make a fork on github, setup some tests and stack up some patches.

11/18/12 06:56:41 changed by rjollos

  • status changed from new to closed.
  • resolution set to fixed.

(In [12369]) Fixes #10634: Converted tabs to spaces and fixed indentation.

11/18/12 06:58:42 changed by rjollos

(In [12370]) Refs #10634: Applied misc formatting changes (applied via PyDev autoformatting) to conform to PEP8.

(in reply to: ↑ 1 ; follow-up: ↓ 7 ) 11/18/12 11:21:53 changed by psuter

Replying to rjollos:

This plugin is completely broken as far as I can tell. I've had to make a dozen changes just to get it partially working. Is anyone actually using this?

I'm not a heavy user and I haven't tested it much, but I've had it installed for some time and it seemed to do the job. What problems did you see?

(in reply to: ↑ 6 ) 11/18/12 11:27:12 changed by rjollos

Replying to psuter:

I'm not a heavy user and I haven't tested it much, but I've had it installed for some time and it seemed to do the job. What problems did you see?

I made a few comments over in #10635. The first issue I had was due to not reading the documentation well enough, but there is also a more subtle problem having to do with not performing fine-grained checks for WIKI_CREATE. I plan to fix that issue and clean up some of the code in #10635.

Add/Change #10634 (Source has tabs and improper indentation)




Change Properties
Action