Ticket #10635 (new defect)

Opened 6 months ago

Last modified 6 months ago

Plugin is not working with Trac 1.1.1dev

Reported by: rjollos Assigned to: natewlew
Priority: normal Component: PrivateWikiPlugin
Severity: normal Keywords:
Cc: psuter Trac Release: 1.2

Description

As mentioned in #10634, the plugin isn't working for me with Trac 1.1.1dev. I'll provide some tests and patches in this ticket to try and determine what the issue is.

Attachments

Change History

(follow-up: ↓ 2 ) 11/18/12 10:14:32 changed by rjollos

My mistake. I had overlooked this line on the main page: Enter the pages in all upper case and replace /'s with _. What is really confusing is that the default value for private_wikis is not all uppercase (default='Private'). It seems like we can avoid that constraint with some simple changes though.

Another issue I've found is that the plugin doesn't do fine-grained checks for the WIKI_CREATE action. If the user has view but not edit permission for a private page, then they will be able to create the page, or any subpage. The user won't be able to edit the page after creation though.

I have unit tests wired up now, so I'll start applying fixes tomorrow and push the changes to my BitBucket branch, requesting your review.

(in reply to: ↑ 1 ) 11/19/12 05:49:03 changed by rjollos

  • cc set to psuter.

Replying to rjollos:

Another issue I've found is that the plugin doesn't do fine-grained checks for the WIKI_CREATE action.

I appreciate if anyone else is able to confirm this defect. It should be fairly simple to reproduce. Just login as a user with PRIVATE_VIEW_<page> and try to create a non-existent page below page/.

Add/Change #10635 (Plugin is not working with Trac 1.1.1dev)




Change Properties
Action