Ticket #10740 (new defect)

Opened 5 months ago

Last modified 5 months ago

[Patch] Checkbox columns are too wide on the Accounts: Cleanup page

Reported by: rjollos Assigned to: hasienda
Priority: normal Component: AccountManagerPlugin
Severity: minor Keywords: web-UI CSS
Cc: Trac Release: 1.2

Description

In Trac 1.1.1dev (and probably some earlier versions), the column of checkboxes is too wide.

Attachments

AccountsCleanup.png (27.3 kB) - added by rjollos on 12/30/12 20:48:27.
AccountsCleanup2.png (22.1 kB) - added by rjollos on 12/30/12 20:53:40.
th10740-r12491-1.patch (0.5 kB) - added by rjollos on 12/30/12 21:00:59.

Change History

12/30/12 20:48:27 changed by rjollos

  • attachment AccountsCleanup.png added.

12/30/12 20:53:40 changed by rjollos

  • attachment AccountsCleanup2.png added.

12/30/12 20:56:50 changed by rjollos

  • summary changed from Checkbox columns are too wide on the Accounts: Cleanup page to [Patch] Checkbox columns are too wide on the Accounts: Cleanup page.

The attached patch uses a class from admin.css, the same class that several other tables in the admin realm use, including the Ticket Components table. After this page, the checkboxes columns are the same width as I see on a Trac 0.12.3 installation.

12/30/12 21:00:59 changed by rjollos

  • attachment th10740-r12491-1.patch added.

12/30/12 21:25:21 changed by hasienda

  • release set to 1.2.
  • keywords set to web-UI CSS.
  • severity changed from normal to minor.

I can't reproduce this, at least not with Trac-1.0, but I trust you, and the change looks non-intrusive. So I'll apply this right-way, and profit once I'll go forward towards Trac trunk again.

12/30/12 21:48:32 changed by rjollos

I'm curious as to what might have changed between Trac 1.0 and the current 1.1.dev, so I'll be digging deeper on this one and will report back here.

I noticed that the table on the Manage User Accounts page also uses the sel class for the header column of checkboxes, same as the Ticket Components table and others. If I remove the class from that table, I also get the larger column width in Trac 1.1.1dev.

12/30/12 22:21:24 changed by hasienda

This sounds like an explanation. Must have copied this from Trac for the older tables already due to similar experiences in the past, yes.

12/30/12 22:27:51 changed by hasienda

(In [12493]) AccountManagerPlugin: Keep table columns narrow in db clean-up admin page too, refs #10740.

This isn't visible in Trac 1.0 and below, but has been reported for latest Trac trunk. Thanks to Ryan J Ollos for taking care.

(follow-up: ↓ 7 ) 12/31/12 19:12:40 changed by rjollos

While working on t:#11003, I noticed that the sel class is applied to the td elements in the column for the tables in the admin realm, such as Ticket Components table. There doesn't appear to be any special CSS that applies to the td.sel selector, but I wonder if it would be good practice to apply the sel class to the td elements here as well. This would keep the tables consistent in the case of future CSS changes in Trac.

(in reply to: ↑ 6 ) 01/02/13 11:40:45 changed by rjollos

Replying to rjollos:

While working on t:#11003, I noticed that the sel class is applied to the td elements in the column for the tables in the admin realm, such as Ticket Components table. There doesn't appear to be any special CSS that applies to the td.sel selector, but I wonder if it would be good practice to apply the sel class to the td elements here as well. This would keep the tables consistent in the case of future CSS changes in Trac.

This is added (out of necessity) in the patch for #10745.

Add/Change #10740 ([Patch] Checkbox columns are too wide on the Accounts: Cleanup page)




Change Properties
Action