Modify

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#10800 closed defect (fixed)

Error when theme is not defined

Reported by: me@… Owned by: olemis
Priority: normal Component: ThemeEnginePlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description (last modified by rjollos)

When the theme entry is not configured in trac.ini there is an error raised,

Trac detected an internal error:
TypeError: argument of type 'NoneType' is not iterable

File "/usr/lib/python2.6/dist-packages/trac/web/main.py", line 450, in _dispatch_request
  dispatcher.dispatch(req)
File "/usr/lib/python2.6/dist-packages/trac/web/main.py", line 217, in dispatch
  self._post_process_request(req, *resp)
File "/usr/lib/python2.6/dist-packages/trac/web/main.py", line 309, in _post_process_request
  resp = f.post_process_request(req, *resp)
File "/usr/local/lib/python2.6/dist-packages/TracThemeEngine-2.1.1-py2.6.egg/themeengine/web_ui.py", line 63, in post_process_request
  if 'css' in theme:

I attached a quick patch for this. I am still new to python so not sure if this is the best method.

Attachments (1)

10800.patch (494 bytes) - added by me@… 2 years ago.
Possible patch for #10800

Download all attachments as: .zip

Change History (4)

Changed 2 years ago by me@…

Possible patch for #10800

comment:1 Changed 2 years ago by rjollos

  • Description modified (diff)

comment:2 Changed 2 years ago by olemis

  • Resolution set to fixed
  • Status changed from new to closed

(In [12534]) ThemeEnginePlugin: [regression] Theme struct will be None if no theme configured or set to 'default' - refs #10748 fixes #10800

comment:3 Changed 2 years ago by olemis

Notice that this issue was reported for Trac=0.11 . However the defect was detected in trunk .

Following Trac policies , support for 0.11 is not available anymore , which means two things :

  1. 0.11 installations should be checking out the plugin's 0.11 branch
  2. 2.1.x series implemented in trunk are focused on 1.0 compatibility . Hence modifications incorporated in there might be incompatible with previous versions . You may check out new versions as long as they still work , but we do not take backwards compatibility into account when committing into trunk .

Thanks for your interest in the plugin ! :)

Add Comment

Modify Ticket

Action
as closed The owner will remain olemis.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.