Ticket #10800 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

Error when theme is not defined

Reported by: me@scott.cm Assigned to: olemis
Priority: normal Component: ThemeEnginePlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description (Last modified by rjollos)

When the theme entry is not configured in trac.ini there is an error raised, 

Trac detected an internal error:
TypeError: argument of type 'NoneType' is not iterable

File "/usr/lib/python2.6/dist-packages/trac/web/main.py", line 450, in _dispatch_request
  dispatcher.dispatch(req)
File "/usr/lib/python2.6/dist-packages/trac/web/main.py", line 217, in dispatch
  self._post_process_request(req, *resp)
File "/usr/lib/python2.6/dist-packages/trac/web/main.py", line 309, in _post_process_request
  resp = f.post_process_request(req, *resp)
File "/usr/local/lib/python2.6/dist-packages/TracThemeEngine-2.1.1-py2.6.egg/themeengine/web_ui.py", line 63, in post_process_request
  if 'css' in theme:

I attached a quick patch for this. I am still new to python so not sure if this is the best method.

Attachments

10800.patch (494 bytes) - added by me@scott.cm on 01/16/13 09:40:36.
Possible patch for #10800

Change History

01/16/13 09:40:36 changed by me@scott.cm

  • attachment 10800.patch added.

Possible patch for #10800

01/16/13 20:25:50 changed by rjollos

  • description changed.

01/17/13 15:52:38 changed by olemis

  • status changed from new to closed.
  • resolution set to fixed.

(In [12534]) ThemeEnginePlugin: [regression] Theme struct will be None if no theme configured or set to 'default' - refs #10748 fixes #10800

01/17/13 16:04:27 changed by olemis

Notice that this issue was reported for Trac=0.11 . However the defect was detected in trunk .

Following Trac policies , support for 0.11 is not available anymore , which means two things :

  1. 0.11 installations should be checking out the plugin's 0.11 branch
  2. 2.1.x series implemented in trunk are focused on 1.0 compatibility . Hence modifications incorporated in there might be incompatible with previous versions . You may check out new versions as long as they still work , but we do not take backwards compatibility into account when committing into trunk .

Thanks for your interest in the plugin ! :)

Add/Change #10800 (Error when theme is not defined)




Change Properties
Action