Modify

Opened 11 years ago

Last modified 4 years ago

#10902 new task

Unifiy user rename function in AccountManagerPlugin

Reported by: Steffen Hoffmann Owned by: Martin Scharrer
Priority: normal Component: RenameUserPlugin
Severity: normal Keywords: rename user
Cc: Trac Release: 0.11

Description

I've had a quick look into the code.

Especially the modular concept is interesting, because I had something similar in mind for AccountManagerPlugin, where it would fit very well.

Do not use it yet. for months is not so encouraging to users. Especially I'd hate to create the 4rd instance for a similar functionality (see RenameUsersScript and RenameTracUsersScript for earlier approaches on the same topic). Ideally we should create one working and maintained code.

How do you think about joining efforts?

Attachments (0)

Change History (9)

comment:1 Changed 11 years ago by Steffen Hoffmann

See #10900 and #10901 as related requests.

comment:2 Changed 11 years ago by Steffen Hoffmann

It seems like there is no real db access code in this plugin yet. And while I appreciate GPL as a free license, it is in general prohibitive for re-using code in AccountManager that happens to use the 3-clause BSD license.

comment:3 Changed 11 years ago by Steffen Hoffmann

(In [12700]) AccountManagerPlugin: Introduce code for changing session IDs consistently, refs #10900, #10901 and #10902.

There are actually three predecessors to this code (in creation time order): RenameUsersScript, RenameTracUsersScript and RenameUserPlugin. While the scripts yield some hints on how to approach the task, the last one is the most complete in terms of a real API, but can't be used for having the viral GPL license attached, that would interfere and overpower the modified BSD, that we use with this plugin.

So this is neither fresh code nor copied verbatim but something in-between. I'm grateful and therefor grant every author of the aforementioned hacks my respect for going ahead and sharing their solution with us.

You're welcome to join and help improve my attempt, that aims at obsoleting all others by providing the best in Trac integration, flexibility, reliability and performance. Especially user ID changes in the Cc ticket field and corresponding change records are not supported yet.

comment:4 Changed 11 years ago by Steffen Hoffmann

(In [12701]) AccountManagerPlugin: Adding admin web-UI parts for new user ID change code, refs #10900, #10901 and #10902.

comment:5 Changed 11 years ago by Steffen Hoffmann

(In [12702]) AccountManagerPlugin: Support user ID replacement in Cc ticket field and its changes, refs #10900, #10901 and #10902.

comment:6 Changed 11 years ago by Steffen Hoffmann

(In [12706]) AccountManagerPlugin: Various improvements for user ID change code, refs #10900, #10901 and #10902.

This evolved mostly for adding real transaction error handling, catching common db-related exceptions and for providing a more i18n-friendly and more readable message on success - almost on the edge of my current db foo.

comment:7 Changed 11 years ago by Steffen Hoffmann

(In [12736]) AccountManagerPlugin: Add optional user ID changer components for other plugins, refs #10900, #10901, #10902, #10944 and #10945.

In addition to VotePlugin (supported by RenameTracUsersScript too) support for

is provided within this plugin.

With the publication of this code the requests for feedback are almost obsoleted, even more, because non of the pre-existing solutions provided the coverage and extensibility, that is offered now within this plugin.

comment:8 in reply to:  description Changed 11 years ago by Steffen Hoffmann

Keywords: rename user added
Trac Release: 0.11

Replying to hasienda:

Especially I'd hate to create the 4rd instance for a similar functionality ...

Obviously this wasn't avoidable in this case.

comment:9 Changed 4 years ago by Ryan J Ollos

Cc: Ryan J Ollos removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Martin Scharrer.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.