Change permission action definition for intuitive inheritance

[Steffen Hoffmann]

From description:

If a user has a valid session (created through the Preferences panel) and the VOTE_MODIFY permission, they will be able to vote.

This is not true, because he/she won't currently see the down-/up-vote links at all. Therefore more intuitive permission inheritance is suggested:

a/tracvote/__init__.py

@@ -117 +117 @@
 
     # IPermissionRequestor method
     def get_permission_actions(self):
-        return ['VOTE_VIEW', 'VOTE_MODIFY']
+        action = 'VOTE_VIEW'
+        return [('VOTE_MODIFY', [action]), action]
 
     ### ITemplateProvider methods
 

For what its worth, if you assign someone VOTE_MODIFY, it does actually rely on seeing the vote links, doesn't it?

[Ryan J Ollos]

Yes, make sense. Thanks for catching that. Please feel free to commit.

Wiring up the unit tests has been on my TODO list for this plugin. For this change though, I don't imagine that a unit test is needed. A functional test would be nice, but better to get the fix in there and we'll add the functional test infrastructure when time allows.

[Steffen Hoffmann]

(In [12771]) TracVote: Allow for more intuitive permission setup by action inheritance, closes #10941.

[Steffen Hoffmann]

(In [12775]) VotePlugin: Add an unit test harness, refs #10941.

Including more author comments and explicit license file for clarity.

[Ryan J Ollos]

(In [12814]) Refs #10941: Added license header to setup.py.

[Ryan J Ollos]

(In [12815]) Refs #10941: Replaced a single line containing tab-indentation with space-indentation.