TracStatsPlugin Change 13107 does not properly count batch-modified tickets

[achittur@…]

Change [13107] changed the results of the get_num_closed_tix() and get_num_open_tix() queries. The new version does not cooperate with batch-modified tickets. Neither version completely cooperates with tickets imported with status=closed via the TicketImport plugin.

Reproduction steps:

1. Use TicketImport to import a set of bugs from CSV, some with open status and some with closed.
2. Version [13106] of these methods do not correctly add the already-closed tickets to the new and closed statistics; there also appears to be a miscount. Version [13107] of these methods count the already-closed tickets as still-open.

Attempted failed workaround: Taking all the closed tickets, re-opening and re-closing them still does not get TicketStats to correctly count them.

Note: I am not sure it is entirely possible to get accurate statistics just by looking at the ticket_change table. The [13106] version of these queries look like they'll provide more accurate results. I believe it is far more important to users for these statistics to be accurate rather than fast.

[achittur@…]

Partially reverted & corrected ticketstats.py

[Ryan J Ollos]

Could you please attach that as a patch, per ​t:TracDev/SubmittingPatches?