Modify

Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#11166 closed enhancement (fixed)

About timeline filter behavior

Reported by: anonymous Owned by: falkb
Priority: normal Component: SimpleMultiProjectPlugin
Severity: minor Keywords:
Cc: ykrocku@… Trac Release: 1.0

Description (last modified by rjollos)

In timeline page, there is a "Filter projects" option added by simple multiproject plugin. It only display the selected project's events when a project selected.
I got a little confused about the 'ALL' option.I assume the 'ALL' option shouldn't filter out any events, but indeed it filter out changes made to those tickets without its custom field 'project' set.

Here is the way I think 'ALL' option should work

if template == 'timeline.html':
    filter_projects = self._filtered_projects(req)
    if not filter_projects: #no filter means likely more than 1 project, so we insert the project name
-        filter_projects = [project[1] for project in self.__SmpModel.get_all_projects()]
+        return template, data, content_type

Attachments (0)

Change History (8)

comment:1 Changed 14 months ago by ykrocku@…

  • Cc ykrocku@… added

Forget to add my email address

comment:2 follow-up: Changed 14 months ago by anonymous

Wouldn't the patch result in not having the yellow project label anymore, for all the tickets where 'project' is set?

comment:3 in reply to: ↑ 2 Changed 14 months ago by ykrocku@…

Replying to anonymous:

Wouldn't the patch result in not having the yellow project label anymore, for all the tickets where 'project' is set?

Yeah, but I think it is better than the way it works now.

comment:4 Changed 14 months ago by falkb

  • Status changed from new to assigned

comment:5 Changed 14 months ago by falkb

In 13291:

bugfix: if "All" is set as timeline filter, display also tickets without a set project (refs #11166)

comment:6 Changed 14 months ago by falkb

ykrocku, please test and close this ticket if it's OK now. Thanks a lot for reporting.

comment:7 Changed 14 months ago by ykrocku@…

  • Resolution set to fixed
  • Status changed from assigned to closed

Test ok

comment:8 Changed 14 months ago by rjollos

  • Description modified (diff)

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from falkb. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.