iframe YouTube embed

[Mitar]

YouTube uses iframe now to embed. This patch upgrades the macro to use it:

movie/macro.py

@@ -98 +98 @@
             query_dict = xform_query(query)
             video = query_dict.get('v')
             
-            url = urlunparse((scheme, netloc, '/v/%s' % video, '', '', ''))
+            url = urlunparse((scheme, netloc, '/embed/%s' % video, '', '', ''))
             
             width = kwargs.pop('width', style_dict.get('width', '425px'))
             height = kwargs.pop('height', style_dict.get('height', '344px'))
@@ -108 +108 @@
                 'height': height,
             })
             
-            return tag.object(tag.param(name='movie', value=url),
-                              tag.param(name='allowFullScreen', value='true'),
-                              tag.embed(src=url, type='application/x-shockwave-flash', allowfullscreen='true', width=width, height=height),
-                              style=xform_style(style))
+            return tag.iframe(src=url, allowfullscreen='allowfullscreen', frameborder='0', width=width, height=height, style=xform_style(style))
         
         if netloc == 'video.google.com':
             query_dict = xform_query(query)

[Ryan J Ollos]

mitar: If you'd like, I can give you commit access to push the change directly.

[Mitar]

Why not. :-)

But now I see that this patch would break backwards compatibility. If somebody is having old style URLs (with /v/). We should try to parse both.

[Ryan J Ollos]

Alright good sir, you now have r/w access to moviemacro​.

In the past I just did a little bit of work on the plugin since lcordier doesn't seem to be around any longer. If you'd like to formally adopt the plugin, I can also set you as Component owner so that new tickets will be assigned to you. For now, I've just added you to the ACL for SVN access.

Btw, I'm planning to follow-up on your last email of ideas for improving trac-hacks as soon as I get the site fully up to par again.

[Mitar]

No need for more official maintenance. I am just maintaining some old installations and fixing things as I encounter them. No time for something more.

[Tetsuya Morimoto]

For review or as a history.

​https://github.com/arielnetworks/TracMovieMacro/commit/30722a666ba8d017f9523b1fba9a0718c0e94d8b

[Tetsuya Morimoto]

see also to pass parameters: #6374

[Tetsuya Morimoto]

This change has been included in 0.3 version (ticket:12046#comment:2).

[Mitar]

Thanks!