Cannot install ThemeEnginePlugin 2.2.2 cause of "running compile_catalog_js"

[Jun Omae]

bdist_egg command raises the following error. Also easy_install raises the same. The issue is originally from ​http://14code.com/blog/20140303_664.

$ ~/venv/trac/0.12.5/bin/python setup.py bdist_egg
running bdist_egg
running egg_info
writing requirements to TracThemeEngine.egg-info/requires.txt
writing TracThemeEngine.egg-info/PKG-INFO
writing top-level names to TracThemeEngine.egg-info/top_level.txt
writing dependency_links to TracThemeEngine.egg-info/dependency_links.txt
writing entry points to TracThemeEngine.egg-info/entry_points.txt
reading manifest file 'TracThemeEngine.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '*.pyc' found anywhere in distribution
warning: no previously-included files matching '*.swp' found anywhere in distribution
warning: no previously-included files matching '*.swo' found anywhere in distribution
warning: no previously-included files matching '*.mo' found anywhere in distribution
writing manifest file 'TracThemeEngine.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-i686/egg
running install_lib
running compile_catalog_js
error: you must specify either the input file or the base directory

The plugin seems that it should use get_l10n_cmdclass instead of get_l10n_js_cmdclass, as it doesn't use message files for javascript.

setup.py

@@ -14 +14 @@
 
 extra = {}
 try:
-    from trac.util.dist import get_l10n_js_cmdclass
-    cmdclass = get_l10n_js_cmdclass()
+    from trac.util.dist import get_l10n_cmdclass
+    cmdclass = get_l10n_cmdclass()
     if cmdclass:
         extra['cmdclass'] = cmdclass
         extractors = [

[Olemis Lang]

In 13718:

ThemeEnginePlugin [ fixes #11606 ] : Include the right i18n distutils cmd (no js)

... formerly breaking bdist_* commands.

[Ryan J Ollos]

Just wondering, what is the reason for including *.po and *pot in the package data? Trac does not seem to do the same: ​trac:browser:/tags/trac-1.0.1/setup.py?marks=83-92#L56

[Olemis Lang]

To declare them as ​package data . Any other suggestion ?

[Ryan J Ollos]

Let me rephrase the question. Why do you think it is necessary to include *.po and *.pot files as package data? I think only the compiled catalogs need to be included, and the setup.py for Trac and Bloodhound would seem to support this.

[Olemis Lang]

It seems I see what you mean now , including .mo files only in bdist packages and .po , .pot only in source tarballs . Is this the case ?

[Ryan J Ollos]

I think that is the case, but I'm by no means an expert.

[Jun Omae]

We could remove *.po and *.pot files from the package_data. But the removing leads KeyError: 'themeengine/locale' from resource_filename(__name__, 'locale') if Babel isn't installed.

We should handle a KeyError or check the existence of locale directory using resource_isdir().

setup.py

@@ -41 +41 @@
                                      'htdocs/farbtastic/*.png',
                                      'htdocs/farbtastic/*.js',
                                      'htdocs/farbtastic/*.css',
-                                     'locale/*.pot',
-                                     'locale/*/LC_MESSAGES/*.po',
                                      'locale/*/LC_MESSAGES/*.mo'] },
     author = 'Noah Kantrowitz',
     author_email = 'noah@coderanger.net',

themeengine/api.py

@@ -107 +107 @@
 
     def __init__(self):
         import pkg_resources
-        locale_dir = pkg_resources.resource_filename(__name__, 'locale')
-        add_domain(self.env.path, locale_dir)
+        try:
+            locale_dir = pkg_resources.resource_filename(__name__, 'locale')
+        except KeyError:
+            pass
+        else:
+            add_domain(self.env.path, locale_dir)
 
         if lazy is None:
             # Trac < 1.0 : this can safely go in here because the data can

[Olemis Lang]

I honestly do not like over-complicating the code for this. Initialization code must take for granted the existence of locale folder and setup.py code must ensure that this will be the case .

[Olemis Lang]

In 13789:

ThemeEnginePlugin [ refs #11606 ] Do not copy .po and .pot files in bdist archives
Ensure that locale folder will always be deployed thus avoiding KeyError .

[Olemis Lang]

@jun66j5 please take a look . Other translations are welcome as well .

[Jun Omae]

Looks good to me.

$ rm -f themeengine/locale/*/LC_*/*.mo
$ rm -rf build dist
$ ~/venv/trac/0.12.5-nobabel/bin/python setup.py bdist_egg
...
$ unzip -l dist/TracThemeEngine-2.2.2dev-py2.4.egg | grep locale
      187  03-24-14 00:26   themeengine/locale/README.txt