Modify

Opened 7 years ago

Closed 4 years ago

#1602 closed enhancement (fixed)

[patch] Pass old_password when changing password

Reported by: g2p Owned by: hasienda
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: authentication ldap
Cc: Trac Release: 0.10

Description

This patch changes the prototype of set_password to take an additional parameter, old_password. This is necessary for changing passwords on an LDAP server (the patch at #1600 ). The new parameter has a default value of None, so that the API remains compatible.

Attachments (2)

Change History (7)

comment:1 follow-up: Changed 4 years ago by lruiz

Hi, this is an important patch for those using LDAP, could someone apply this patch to the code baseline?

comment:2 in reply to: ↑ 1 Changed 4 years ago by hasienda

  • Keywords needinfo authentication ldap added
  • Owner changed from mgood to hasienda
  • Summary changed from [PATCH] pass old_password when changing password to [patch] Pass old_password when changing password

Replying to lruiz:

Hi, this is an important patch for those using LDAP, could someone apply this patch to the code baseline?

Hello, I've just taken over maintainership and going through the massive pile of tickets here. Saying sorry for all the time, this and many other patches have been sleeping here doesn't help. I'll be up to apply patches, as my time permits and following priority.

A short reply would help me to decide, if this one here is still relevant for 0.10 branch, trunk or both, and of course your vote would influence handling of #1602 as well.

comment:3 follow-up: Changed 4 years ago by lruiz

It is still valid.

comment:4 in reply to: ↑ 3 Changed 4 years ago by hasienda

  • Keywords needinfo removed
  • Status changed from new to assigned

Replying to lruiz:

It is still valid.

Thanks for the confirmation. So this will be another addition to my patch stack.

comment:5 Changed 4 years ago by hasienda

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [9275]) AccountManagerPlugin: Add optional attribute old_password to set_password method, closes #1602.

This is a backwards-compatible API change. It's meant to prepare for
adding AuthStores, that need to know both, old and new password
for password change, like the proposed LdapAuthStore, refs #1600.
Unittests are added to cover the method extension as well.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from hasienda. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.