Ticket #1602 (closed enhancement: fixed)

Opened 6 years ago

Last modified 3 years ago

[patch] Pass old_password when changing password

Reported by: g2p Assigned to: hasienda
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: authentication ldap
Cc: Trac Release: 0.10

Description

This patch changes the prototype of set_password to take an additional parameter, old_password. This is necessary for changing passwords on an LDAP server (the patch at #1600 ). The new parameter has a default value of None, so that the API remains compatible.

Attachments

password-update.patch (3.0 kB) - added by g2p on 06/03/07 02:12:36.
Patch against http://trac-hacks.org/svn/accountmanagerplugin/trunk
password-update.2.patch (2.5 kB) - added by g2p on 06/03/07 02:14:03.
Patch against http://trac-hacks.org/svn/accountmanagerplugin/0.10

Change History

06/03/07 02:12:36 changed by g2p

  • attachment password-update.patch added.

Patch against http://trac-hacks.org/svn/accountmanagerplugin/trunk

06/03/07 02:14:03 changed by g2p

  • attachment password-update.2.patch added.

Patch against http://trac-hacks.org/svn/accountmanagerplugin/0.10

(follow-up: ↓ 2 ) 03/05/10 00:27:19 changed by lruiz

Hi, this is an important patch for those using LDAP, could someone apply this patch to the code baseline?

(in reply to: ↑ 1 ) 10/06/10 21:49:41 changed by hasienda

  • keywords set to needinfo authentication ldap.
  • owner changed from mgood to hasienda.
  • summary changed from [PATCH] pass old_password when changing password to [patch] Pass old_password when changing password.

Replying to lruiz:

Hi, this is an important patch for those using LDAP, could someone apply this patch to the code baseline?

Hello, I've just taken over maintainership and going through the massive pile of tickets here. Saying sorry for all the time, this and many other patches have been sleeping here doesn't help. I'll be up to apply patches, as my time permits and following priority.

A short reply would help me to decide, if this one here is still relevant for 0.10 branch, trunk or both, and of course your vote would influence handling of #1602 as well.

(follow-up: ↓ 4 ) 10/07/10 06:59:19 changed by lruiz

It is still valid.

(in reply to: ↑ 3 ) 10/07/10 10:58:13 changed by hasienda

  • status changed from new to assigned.
  • keywords changed from needinfo authentication ldap to authentication ldap.

Replying to lruiz:

It is still valid.

Thanks for the confirmation. So this will be another addition to my patch stack.

10/09/10 21:14:44 changed by hasienda

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [9275]) AccountManagerPlugin: Add optional attribute old_password to set_password method, closes #1602.

This is a backwards-compatible API change. It's meant to prepare for adding AuthStores?, that need to know both, old and new password for password change, like the proposed LdapAuthStore?, refs #1600. Unittests are added to cover the method extension as well.

Add/Change #1602 ([patch] Pass old_password when changing password)




Change Properties
Action