Ticket #1600 (new enhancement)

Opened 3 years ago

Last modified 5 months ago

[PATCH] Authentication support

Reported by: Tobu Assigned to: .
Priority: normal Component: LdapPlugin
Severity: normal Keywords: patch,ldap,accountmanager,authentication
Cc: Tobu Trac Release: 0.10

Description

The patch provides authentication support via LDAP if AccountManagerPlugin is installed.

This allows a user to login, logout, and change their password.

No extra configuration outside of LdapPlugin (enable components, configure ldap) and AccountManagerPlugin (enable components) is required; by default, any user that is a member of the group tracusers is allowed to log in.

Attachments

ldap-auth-store.patch (4.9 kB) - added by Tobu on 06/03/07 02:21:48.
Another iteration, listing users works, and updating the password too (if you apply #1602).
ldap_store.py (4.7 kB) - added by Tobu on 10/22/09 23:23:30.
attachment:ldap-auth-store.patch in non-patch form and with whitespace changes

Change History

06/03/07 02:21:48 changed by Tobu

  • attachment ldap-auth-store.patch added.

Another iteration, listing users works, and updating the password too (if you apply #1602).

09/28/09 17:30:14 changed by k0s

see also #1147 and the various links from that ticket. Not sure if this is a duplicate? If this should be combined, etc.

10/22/09 23:18:54 changed by Tobu

  • cc changed from g2p to Tobu.
  • owner changed from g2p to ..

Thanks k0s for putting this in version control.

Looking at some code comments in common, it seems my implementation shares some code with attachment:ticket:1147:ldap_store.py or some earlier common origin. Unfortunately I don't have VCS of that at hand.

(Aside: I think both tickets exist because this one was meant for the LdapPlugin maintainer rather than the TracAccountManager? maintainer, but it turns out the former was hard to reach at that time. #1147 had two comments then.)

What follows is what I get from diffing my version of ldap_store vs the oldest one on #1147, and vs the one you kept in LdapAuthStore? . I'm re-attaching ldap_store.py with minor spacing/ordering changes for easy diffing.

Compared to attachment:ticket:1147:ldap_store.py , attachment:ldap_store.py has user deletion, password change (but #1602 which makes it work in more cases has never been applied to TracACcountManager), and better authentication support in less code (by binding instead of doing case-by-case crypto by hand). My get_users implementation is configured to list the ldap group as configured in LdapPlugin. OTOH, my implementation has no caching.

Compared to source:ldapauthstoreplugin/0.11/ldapauthstore/ldap_store.py , which mostly adds more cases to the (IMHO superfluous) password handling, those differences subsist.

I'm not running Trac anymore, so I don't expect I'll bring my version up to scratch for LdapAuthStore? .

10/22/09 23:23:30 changed by Tobu

  • attachment ldap_store.py added.

attachment:ldap-auth-store.patch in non-patch form and with whitespace changes


Add/Change #1600 ([PATCH] Authentication support)




Change Properties
Action