Ticket #2312 (closed defect: fixed)

Opened 1 year ago

Last modified 5 months ago

[patch] fixes 0.11 version (makes ticket selection checkboxes appear)

Reported by: gt4329b Assigned to: ashwin_phatak
Priority: high Component: BatchModifyPlugin
Severity: normal Keywords:
Cc: gt4329b@pobox.com Trac Release: 0.11

Description

Pretty much what the summary says. Specifically, the input checkboxes (to select the tickets to apply the batch mods on) weren't appearing.

Digging a bit, it turns out the jQuery code to add the checkboxes wasn't quite right (it was using raw XPath instead of jQuery) -- so I fixed that. Furthermore, the "select group" checkbox didn't work; I didn't spend much time trying to get this working as it wasn't nearly as high a priority, so I just removed the group checkbox. I may come back in the future and attempt to get the group checkbox working, but only if enough of my users scream :)

Attachments

checkboxesfix.r2895.patch (7.6 kB) - added by gt4329b on 12/14/07 17:27:00.
batchmod-jquery1.2.patch (2.1 kB) - added by dgynn on 03/02/08 18:07:25.

Change History

12/14/07 17:27:00 changed by gt4329b

  • attachment checkboxesfix.r2895.patch added.

12/14/07 17:29:10 changed by gt4329b

For whatever reason, the attached .patch file doesn't preview properly in Trac, but it's fine if you download it (use the Original Format link at the bottom of the preview page).

03/02/08 18:07:25 changed by dgynn

  • attachment batchmod-jquery1.2.patch added.

03/02/08 18:11:22 changed by dgynn

Added a new patch that works with jQuery in no-conflict mode and uses CSS selectors instead of XPath like gt4329b's. This patch also fixes the group toggle boxes.

04/08/08 06:15:11 changed by anonymous

dgynns patch fixes the problem for me. this should be incorporated into the next release imo - else this plugin doesn't work at all in firefox.

04/12/08 00:19:35 changed by ijones

works for me in firefox (3.0b5) - I would also vote for incorporation.

04/24/08 08:31:48 changed by anonymous

Added glee: the jQuery patch (batchmod-jquery1.2.patch) also caused the batch modify controls to start working again in Opera 9.27. Previously they were broken (checking the checkbox next to a field would do nothing, the field would remain disabled) for Opera, but worked in Firefox 2.0.0.12.

06/27/08 07:42:14 changed by bas

Just installed the plugin and had to apply this patchto make thing work. When will this patch be applied?

06/29/08 11:29:30 changed by dgynn

  • status changed from new to closed.
  • resolution set to fixed.

Fixed. Patch applied in changeset:3916

Add/Change #2312 ([patch] fixes 0.11 version (makes ticket selection checkboxes appear))




Change Properties
Action