Modify

Opened 7 years ago

Closed 6 years ago

Last modified 13 months ago

#2312 closed defect (fixed)

[patch] fixes 0.11 version (makes ticket selection checkboxes appear)

Reported by: gt4329b Owned by: ashwin_phatak
Priority: high Component: BatchModifyPlugin
Severity: normal Keywords:
Cc: gt4329b@… Trac Release: 0.11

Description

Pretty much what the summary says. Specifically, the input checkboxes (to select the tickets to apply the batch mods on) weren't appearing.

Digging a bit, it turns out the jQuery code to add the checkboxes wasn't quite right (it was using raw XPath instead of jQuery) -- so I fixed that. Furthermore, the "select group" checkbox didn't work; I didn't spend much time trying to get this working as it wasn't nearly as high a priority, so I just removed the group checkbox. I may come back in the future and attempt to get the group checkbox working, but only if enough of my users scream :)

Attachments (2)

checkboxesfix.r2895.patch (7.6 KB) - added by gt4329b 7 years ago.
batchmod-jquery1.2.patch (2.1 KB) - added by dgynn 6 years ago.

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by gt4329b

comment:1 Changed 7 years ago by gt4329b

For whatever reason, the attached .patch file doesn't preview properly in Trac, but it's fine if you download it (use the Original Format link at the bottom of the preview page).

Last edited 13 months ago by rjollos (previous) (diff)

Changed 6 years ago by dgynn

comment:2 Changed 6 years ago by dgynn

Added a new patch that works with jQuery in no-conflict mode and uses CSS selectors instead of XPath like gt4329b's. This patch also fixes the group toggle boxes.

comment:3 Changed 6 years ago by anonymous

dgynns patch fixes the problem for me. this should be incorporated into the next release imo - else this plugin doesn't work at all in firefox.

comment:4 Changed 6 years ago by ijones

works for me in firefox (3.0b5) - I would also vote for incorporation.

comment:5 Changed 6 years ago by anonymous

Added glee: the jQuery patch (batchmod-jquery1.2.patch) also caused the batch modify controls to start working again in Opera 9.27. Previously they were broken (checking the checkbox next to a field would do nothing, the field would remain disabled) for Opera, but worked in Firefox 2.0.0.12.

comment:6 Changed 6 years ago by bas

Just installed the plugin and had to apply this patchto make thing work. When will this patch be applied?

comment:7 Changed 6 years ago by dgynn

  • Resolution set to fixed
  • Status changed from new to closed

Fixed. Patch applied in changeset:3916

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.