Underscores in status names befoul some of the reports

[Russ Tyndall]

In the reports if there are underscores in the status name, the status gets screwed up.

Original Report

On another note - when I added the sample "enterprise" workflow from the Trac 0.11b1 distribution, which has '_' in some of the status names such as in_QA and post_review, the T&E report manager upgrade added the new statuses to the queries OK but when I executed queries from the Management tab, they failed complaining about missing $IN (and when I defined $IN, missing $POST). The query had $IN_QA and $POST_REVIEW defined so it would seem underscore is not a legal character. Once I removed the underscores from the status names in the workflow, T&E reports executed just fine. I don't know if this is a problem with Python, PostgreSQL, or something else (I'm a C++/Java developer, not Python nor SQL).

[anonymous]

I just noticed this issue as well. Adding a comment here to hope it gets some legs. I did exactly the same, adding the Enterprise workflow, and this tool. The question I think this boils down to is:

Does the this plugin need work to try and handle this problem, OR does the wiki page for this plugin need to state that workflow states can not have underscores? Depends on the amount of work to handle it I suppose.

Thanks.

[Russ Tyndall]

I've just been busy. I will attempt to get this rolled in in the next revision of the plugin. It shouldnt be hard to fix. I just need to actually get it done.

Alternatively if you dont want to wait, my idea had just been to strip out underscores before mapping them to report variables. If you provide a patch I am more than happy to apply it.

[Russ Tyndall]

(In [3521]) closes #2862 closes #2763

Fixed reports for mysql. Also made the plugin handle status names that contain an underscore.

version 0.6.5