Behaviour change of showing Custom Query in mainnav as result of #1289 and #1337 fixes

[cmsupport@…]

We use this plugin on our internal projects in a way were we only allow access to the batch modify function to certain groups of users. (like: developers cannot use it, configuration managers, project leaders can). So developers don't have TICKET_BATCH_MODIFY permissions in this setup.

Using the ​1379 version of this plug-in this worked nicely. Developers would see a Custom Query link at the mainnav bar and that showed them a Custom Query screen without the batch modify functions at the bottom of the page.

After upgrading to ​3254 the behavior changed. Developers did not see the Custom Query link in the mainnav bar anymore and I could not get it shown again by adding it to mainnav in trac.ini. They could, however, still access the custom query going directly to the URL or using a stored custom query on a wiki page or in a bookmark. Groups having TICKET_BATCH_MODIFY rights continued to see the Custom Query link.

I tried to revert only changeset [3254] but that did not fix the problem. Reverting also [2771] restored the functionality.

I did upgrade to have a fix for #1337.

I think this change is unwanted. Users not having TICKET_BATCH_MODIFY but having general ticket viewing and modifying permissions are allowed to use Custom Queries (without the batch modify addition) so the link should be shown.

[thomasvs]

[3254] fixed the same problem for me as well. Looking at #1289, which was the reason for [3254], I would say that that changeset was wrong - it should have checked for TICKET_VIEW permissions instead.

However, the author doesn't seem very responsive.

[CuriousCurmudgeon]

This will not be fixed since 0.10 support is being ended. The Custom Query link change was not needed in 0.11