Modify

Opened 6 years ago

Closed 4 years ago

#3921 closed enhancement (fixed)

[Patch] Configuration options for default values and YUI base URL

Reported by: simon@… Owned by: echo0101
Priority: normal Component: TracTicketStatsPlugin
Severity: normal Keywords:
Cc: simon@… Trac Release: 0.11

Description

To get TracTicketStatsPlugin working on our intranet I needed to change the URLs to various YUI scripts to a local YUI setup. I'd like this to be configurable.

I have attached a patch attached that adds a configuration option, yui_base_url, as well as options for the default interval and days to show on the graph, under a ticketstats section.

Attachments (1)

ticketstats-r7633.patch.tgz (1.7 KB) - added by anonymous 5 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 6 years ago by simon@…

Attachment got rejected as spam because of too many external URLs. Find the patch at: http://bleah.co.uk/~simon/stuff/ticketstats-conf.diff

comment:2 Changed 6 years ago by anonymous

Added a '/' after yui_base_url in the template, so both http://yui.yahooapis.com/2.5.2/ and http://yui.yahooapis.com/2.5.2 work.

comment:3 Changed 5 years ago by echo0101

  • Resolution set to fixed
  • Status changed from new to closed

Applied patch in [6379].

Thanks!

comment:4 Changed 5 years ago by anonymous

  • Resolution fixed deleted
  • Status changed from closed to reopened

The trunk seems to haven't applied the patch. I attach the patch file for the review 7633. Thanks!

Changed 5 years ago by anonymous

comment:5 Changed 4 years ago by rjollos

  • Summary changed from Configuration options for default values and YUI base URL to [Patch] Configuration options for default values and YUI base URL

comment:6 Changed 4 years ago by rjollos

It appears that the code on the trunk defines the option yui_base_url, but then does not use it.

comment:7 Changed 4 years ago by rjollos

The syntax used in this patch is clearsilver templating syntax. The replacement <?cs var:yui_base_url ?> -> ${yui_base_url} should be made.

comment:8 Changed 4 years ago by rjollos

This feature was implemented for the TracMetrixPlugin in #5322.

comment:9 Changed 4 years ago by rjollos

This will be added in the next commit. Can someone let me know what is the typical location that the Yahoo APIs would be placed in a local installation?

comment:10 Changed 4 years ago by rjollos

(In [8638]) Added option to allow YUI base URL to be specified in trac.ini. Refs #3921.

comment:11 Changed 4 years ago by rjollos

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [8642]) Re-implementing changes from [8414] on new 0.12 branch. Fixes #3921.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.