HoursRemaining macro ignores closed_states of tickets

[anonymous]

The burndown chart treats a closed ticket as zero hours remaining. However, the macro for calculating the remaining hours does not ignore closed tickets and it could happen that a different number is shown if a user doesn't manually set closed tickets to zero. Probably all macros should behave the same way, otherwise it becomes confusing if one shows a different (incorrect) result.

The problem exists in 0.10 and 0.11 (trunk).

[Joachim Hoessler]

If you don't want to count remaining hours of closed tickets in the HoursRemaing macro, you can specify that as argument: [[HoursRemaining(status=~closed)]]

But you're right, the calculation of the different macros should be consistent.

[osimons]

(In [8758]) EstimationToolsPlugin: Quite a big batch of fixes and tweaks...

Issues resolved:

• Value only saved if actually changed, and if input is a number. Closes #3914
• closed_states are ignored for HoursRemaining macro. Closes #4132
• Ampersands supported in titles, milestones and any query arguments (correcting escaping/quoting). Closes #6889

New features / tweaks:

• Better error messages if no estimation field is configured; macros are disabled and the reason logged as error
• Custom title for the burndown chart
• Set remaining hours to empty instead of '--'
• Implemented decimal support whenever needed (not showing if not used)
• Implemented support for generating charts server-side (a chart proxy), primarily to provide better support for SSL. Option is default disabled
• Inplace editor now also works in wiki and milestone views, typically using TicketQuery macro
• Simplified the edithours.html javascript code + cleaned the code, tabs->spaces
• Obfuscate usernames in case they are email addresses

Tested with 0.11.x and 0.12.x and seems to work fine. Bumped version to 0.4.5.