Modify

Opened 6 years ago

Closed 4 years ago

#3914 closed defect (fixed)

Cannot cancel edit of estimated hours field

Reported by: JasonWinnebeck Owned by: hoessler
Priority: normal Component: EstimationToolsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

After installing plugin on an existing trac with no hour estimates, I see a bunch of values "--". This is not a big deal, but if I click on one of those it starts edit mode, but I can't cancel the edit mode. Instead, if I click off of the value, it saves the value "--" to the actual ticket. Perhaps the value could go to blank/null if it is not a number, and also maybe the ticket shouldn't be updated if the field isn't actually changed.

Attachments (0)

Change History (2)

comment:1 Changed 5 years ago by hoessler

  • Status changed from new to assigned

You can cancel the edit mode by pressing escape. But anyhow, you're right, the value should only be saved if the value has been changed.

comment:2 Changed 4 years ago by osimons

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [8758]) EstimationToolsPlugin: Quite a big batch of fixes and tweaks...

Issues resolved:

  • Value only saved if actually changed, and if input is a number. Closes #3914
  • closed_states are ignored for HoursRemaining macro. Closes #4132
  • Ampersands supported in titles, milestones and any query arguments (correcting escaping/quoting). Closes #6889

New features / tweaks:

  • Better error messages if no estimation field is configured; macros are disabled and the reason logged as error
  • Custom title for the burndown chart
  • Set remaining hours to empty instead of '--'
  • Implemented decimal support whenever needed (not showing if not used)
  • Implemented support for generating charts server-side (a chart proxy), primarily to provide better support for SSL. Option is default disabled
  • Inplace editor now also works in wiki and milestone views, typically using TicketQuery macro
  • Simplified the edithours.html javascript code + cleaned the code, tabs->spaces
  • Obfuscate usernames in case they are email addresses

Tested with 0.11.x and 0.12.x and seems to work fine. Bumped version to 0.4.5.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from hoessler. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.