Modify

Opened 6 years ago

Closed 4 years ago

#4597 closed enhancement (wontfix)

Timeline entries should not be links, when "main_page" is empty

Reported by: Niko_K Owned by: roadrunner
Priority: normal Component: HudsonTracPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

It is a great idea the menu item in the navbar can be disabled, but shouldn't this also apply on timeline entry-links?

On my network hudson is only viewable in the intranet, while trac itself is accessable also via the internet. Therefore links in the timeline view of trac only work in the intranet; when accessing trac via the internet all these links result in "HTTP 404: Not found".

Is there any reason why links in the timeline should not be disabled when main_page in trac.ini is empty?

Attachments (0)

Change History (3)

comment:1 Changed 6 years ago by rodrigo.benenson@…

Well, you may want to keep your navbar non cluttered while having a full featured timeline.

comment:2 follow-up: Changed 6 years ago by roadrunner

I agree - enabling/disabling of the main-menu is really independent of
the timeline.

However, can you explain how the plugin should detect whether to display
in the timeline or not? Or do you want the timeline entries to always be
disabled? If so, why not disable the plugin completely, as it seems to
then provide no useful functionality. What am I missing?

comment:3 in reply to: ↑ 2 Changed 4 years ago by roadrunner

  • Resolution set to wontfix
  • Status changed from new to closed

Replying to roadrunner:

However, can you explain how the plugin should detect whether to display
in the timeline or not? Or do you want the timeline entries to always be
disabled? If so, why not disable the plugin completely, as it seems to
then provide no useful functionality. What am I missing?

Sorry, ignore this - I misunderstood your original request.

However, now that I do, I have to tell you that it not possible to do this
(from within a plugin): the timeline template in trac always creates an
anchor (<a>) tag, i.e. it always creates a link. While I could provide an
option to, say, return empty url's (so that the link just points to the timeline
again), I'm not sure if that's any better than the current error.

I'm therefore closing this ticket - feel free to re-open if you have any
better ideas.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.