[patch] AccountManagerPlugin + Trac 0.12 (no attribute smtp_server)

Log output:

[825Tech log]# cat trac.log

2009-04-07 14:24:37,246 Trac[main] ERROR: Internal Server Error:
Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/Trac-0.12multirepos_r7987-py2.5.egg/trac/web/main.py", line 459, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.5/site-packages/Trac-0.12multirepos_r7987-py2.5.egg/trac/web/main.py", line 214, in dispatch
    resp = chosen_handler.process_request(req)
  File "build/bdist.linux-i686/egg/acct_mgr/web_ui.py", line 397, in process_request
    _create_user(req, self.env)
  File "build/bdist.linux-i686/egg/acct_mgr/web_ui.py", line 70, in _create_user
    mgr.set_password(user, password)
  File "build/bdist.linux-i686/egg/acct_mgr/api.py", line 129, in set_password
    self._notify('created', user, password)
  File "build/bdist.linux-i686/egg/acct_mgr/api.py", line 238, in _notify
    getattr(l, func)(*args)
  File "build/bdist.linux-i686/egg/acct_mgr/notification.py", line 41, in user_created
    notifier.notify(username, 'New user registration')
  File "build/bdist.linux-i686/egg/acct_mgr/notification.py", line 79, in notify
    NotifyEmail.notify(self, username, subject)
  File "/usr/lib/python2.5/site-packages/Trac-0.12multirepos_r7987-py2.5.egg/trac/notification.py", line 328, in notify
    Notify.notify(self, resid)
  File "/usr/lib/python2.5/site-packages/Trac-0.12multirepos_r7987-py2.5.egg/trac/notification.py", line 226, in notify
    self.send(torcpts, ccrcpts)
  File "build/bdist.linux-i686/egg/acct_mgr/notification.py", line 149, in send
    % (self.smtp_server, self.smtp_port, recipients))
AttributeError: 'AccountChangeNotification' object has no attribute 'smtp_server'

It seems that NotifyEmail? class from trac.notification has lost several properties and this Account Manager notification.py hasn't been changed yet.

As a very hotfix you can modify 149 line and exclude missing properties to:

 self.env.log.info("Sending SMTP notification to %s"
                           % (recipients))

This is something related to logging activities and I don't need that at beta build.

Second change will be to comment out

        #self.server.sendmail(msg['From'], recipients, msgtext)

This is notification about account creation.

At lease these changes will allow you to use account manager without email notifications.

Going forward you can try to make the actual change from self.server.sendmail... to something like self.notify... etc.

Replying to bebugz@gmail.com:

This is notification about account creation. At lease these changes will allow you to use account manager without email notifications. Going forward you can try to make the actual change from self.server.sendmail... to something like self.notify... etc.

is there already a propper patch for this problem. so that notification works again ?

Here's a fix:

To notification.py, add at the beginning:

from trac.notification import NotificationSystem

and replace

self.server.sendmail(msg['From'], recipients, msgtext)

with

NotificationSystem(self.env).send_email(msg['From'], recipients, msgtext)

That seems to fix it.

thx for the fix is it already included in svn

In what SVN? As far as I can tell, it has not been commited to trac-hacks SVN...

I need it as well :)

The attached patch fixes AccountManager for trac-0.12. I'm pretty sure this will break 0.11. AccountManager appears to work well in 0.12, with this patch, so maybe it's time for a 0.12 branch?

(In [7737]) Patch from doki_pen. Fixes #4895

Replying to doki_pen:

[...] I'm pretty sure this will break 0.11. AccountManager appears to work well in 0.12, with this patch, so maybe it's time for a 0.12 branch?

Bad news for me, since current code is still meant to be compatible with Trac 0.11, so I'll reopen this issue for the old Trac release, just as a reminder, to check this and possibly work towards a more compatible fix.

Closed #8338 as a duplicate of this issue.

Closed #9032 as a duplicate of this issue, filed against acct_mgr-0.2.1dev-r7163 with Trac 0.11, sadly really no news.