Ticket #5273 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

SyntaxErrors (for python <2.5) in PyGit.py and git_fs.py in revision 5846

Reported by: anonymous Assigned to: hvr
Priority: normal Component: GitPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Syntax Errors:

source:/gitplugin/0.11/tracext/git/git_fs.py#5846#L361

source:/gitplugin/0.11/tracext/git/PyGIT.py#5846#L361 

# python -V
Python 2.4.3

# svn update
At revision 5846.

# python tracext/git/git_fs.py 
  File "tracext/git/git_fs.py", line 361
    yield (self.path, rev, Changeset.EDIT if not is_last else Changeset.ADD)
                                           ^
SyntaxError: invalid syntax

# python tracext/git/PyGIT.py 
  File "tracext/git/PyGIT.py", line 89
    with self.__lock:
            ^
SyntaxError: invalid syntax

Attachments

trac-gitplugin-fix-python-2.4.patch (10.4 kB) - added by Haw Loeung on 07/06/09 08:21:46.
Patch for Python 2.4. Applies cleanly against r6157
trac-gitplugin-fix-python-2.4.2.patch (10.4 kB) - added by Haw Loeung on 07/06/09 08:23:41.
Patch for Python 2.4. Applies cleanly against r6157

Change History

06/01/09 23:46:50 changed by jeremy@jeremyross.org

It looks like python 2.5 is required for the more recent 0.11 versions

06/03/09 08:04:05 changed by anonymous

Is it possible to do for 2.4? I am using RedHat? ?

07/06/09 08:21:46 changed by Haw Loeung

  • attachment trac-gitplugin-fix-python-2.4.patch added.

Patch for Python 2.4. Applies cleanly against r6157

07/06/09 08:23:41 changed by Haw Loeung

  • attachment trac-gitplugin-fix-python-2.4.2.patch added.

Patch for Python 2.4. Applies cleanly against r6157

(follow-up: ↓ 5 ) 07/17/09 18:28:22 changed by anonymous

The patches are empty.

08/09/09 12:37:02 changed by rnavarro@phiivo.com

Haw,

Could you please repost the patches?

(in reply to: ↑ 3 ; follow-up: ↓ 8 ) 08/16/09 02:49:36 changed by roadrunner

  • owner changed from hvr to roadrunner.
  • status changed from new to assigned.

Replying to anonymous:

The patches are empty.

No they aren't - it's just trac's display of the attachment that's broken. Click on the "Original Format" link at the bottom of the page to download the patch and you'll see that they are complete.

08/16/09 02:50:38 changed by roadrunner

  • owner changed from roadrunner to hvr.
  • status changed from assigned to new.

(oops, didn't mean to change the owner)

02/22/10 00:08:58 changed by anonymous

  • summary changed from SyntaxErrors in PyGit.py and git_fs.py in revision 5846 to SyntaxErrors (for python <2.5) in PyGit.py and git_fs.py in revision 5846.

(in reply to: ↑ 5 ) 02/22/10 00:13:50 changed by anonymous

Replying to roadrunner:

Replying to anonymous:

The patches are empty.

No they aren't - it's just trac's display of the attachment that's broken. Click on the "Original Format" link at the bottom of the page to download the patch and you'll see that they are complete.

actually the problem is, that the patch contains binary data, because .pyc files were diffed: 

diff -Naurp tmp/gitplugin/0.11/tracext/__init__.pyc gitplugin/0.11/tracext/__init__.pyc
--- tmp/gitplugin/0.11/tracext/__init__.pyc     1970-01-01 10:00:00.000000000 +1000
+++ gitplugin/0.11/tracext/__init__.pyc 2009-07-06 15:15:16.000000000 +1000

03/07/10 12:25:50 changed by hvr

  • status changed from new to closed.
  • resolution set to fixed.

(In [7752]) branched off python 2.4 backport of 0.11 using attachment:trac-git-plugin-python2.4.patch:ticket:6402

closes #6402 closes #5273 closes #3411 closes #5310

Add/Change #5273 (SyntaxErrors (for python <2.5) in PyGit.py and git_fs.py in revision 5846)




Change Properties
Action