Ticket #5457 (new defect)

Opened 7 months ago

Last modified 1 month ago

[PATCH] After a TracBack reference is added, all subsequent comments are in italics

Reported by: rjollos Assigned to: mchua
Priority: normal Component: TracBacksPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

After a TracBack reference is added to a tickets comment list, all subsequent comments are in Italics. Seems like there is probably a problem with the wiki markup that is generated an inserted for the TracBack reference, such as an unterminated pair single quotes.

See attached screen capture.

Attachments

AllSubsequentCommentsItalics.png (81.2 kB) - added by anonymous on 07/02/09 02:44:34.
0001-TracBacks-Replace-newlines-and-carriage-returns-wit.patch (1.1 kB) - added by JoshuaH on 12/21/09 16:32:23.
Proposed patch

Change History

07/02/09 02:44:34 changed by anonymous

  • attachment AllSubsequentCommentsItalics.png added.

08/18/09 06:40:08 changed by rjollos

See #5456 for a similar issue.

08/18/09 06:41:29 changed by rjollos

This could be caused by or related to a problem with the wiki engine. See Trac Issue #4235 on Edgewall.

09/11/09 23:15:29 changed by rjollos

Appears that it may be related to issue #3232.

12/21/09 16:32:23 changed by JoshuaH

  • attachment 0001-TracBacks-Replace-newlines-and-carriage-returns-wit.patch added.

Proposed patch

12/21/09 16:35:56 changed by JoshuaH

  • summary changed from After a TracBack reference is added, all subsequent comments are in italics to [PATCH] After a TracBack reference is added, all subsequent comments are in italics.

I've attached a patch which appears to fix the problem. Note that it also changes the formatting by replacing newlines with spaces instead of simply removing them.

The plugin strips newlines and adds italics (using '') around the quoted text for a trackback, but failed to strip carriage returns, which were (the theory goes) being interpreted by Trac's Wiki engine as newlines for formatting purposes.

This is probably in part due to Trac not closing formatting properly for list items which was linked above, but this patch should at least produce formatting that doesn't trigger that bug.

01/06/10 00:41:13 changed by rjollos

Thanks for the patch, I will try it out. The underlying issue may be the same as t:#2064.

Add/Change #5457 ([PATCH] After a TracBack reference is added, all subsequent comments are in italics)




Change Properties
Action