Modify

Opened 5 years ago

Closed 5 years ago

#5898 closed enhancement (fixed)

Patch with enhancements

Reported by: szaffarano Owned by: vnaum
Priority: normal Component: CcSelectorPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Adding a attachment with the following changes:

  • Display in the user list the name and e-mail (if they exist).
  • It also changes the way you get the list of users (env.get_known_users()).
  • Minor style changes
  • Minor HTML structure changes

I attached the patch file and a tgz file with the SVN tag 0.11 (rev 6307) patched.

Attachments (2)

ccselector_r6307.patch (6.6 KB) - added by szaffarano 5 years ago.
ccselector_r6307_patched.tgz (6.8 KB) - added by szaffarano 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by szaffarano

Changed 5 years ago by szaffarano

comment:1 Changed 5 years ago by szaffarano

  • Summary changed from Patch with improvements to Patch with enhancements
  • Type changed from defect to enhancement

comment:2 Changed 5 years ago by vnaum

  • Resolution set to fixed
  • Status changed from new to closed

Partially accepted (revision 6631).

Showing email/name: great idea!

HTML/style changes: not so great. Style doesn't fit trac's (we should
probably use trac's styles), and showing additional info on separate
lines takes too much space. Changed it to show as a mailto: link and
title (visible on mouse-over).

Thanks a lot for this patch!

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from vnaum. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.