Modify

Opened 5 years ago

Last modified 21 months ago

#6047 new enhancement

Don't send blog announcement, when `draft` is specified in categories

Reported by: rjollos Owned by: rjollos
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords: blog, FullBlogPlugin
Cc: doki_pen, hasienda Trac Release: 0.11

Description

The FullBlogPlugin has a plugin that implements draft functionality. A draft is specified by entering draft in Categories. It would be a nice feature for the FullBlogNotificationPlugin if emails were not sent when draft was specified in Categories.

Attachments (0)

Change History (20)

comment:1 Changed 5 years ago by rjollos

See also #5556.

comment:2 Changed 5 years ago by rjollos

I'm starting to work on implementing this feature. Initially, I'll aim to have the email sent only to the blog author if draft is specified in the list of tags.

Once that is working, I'll consider adding the following additional logic:

  • Only implement the aforementioned functionality if BlogDraftPlugin is installed.
  • Add the following trac.ini options:
    • notify_if_draft
    • notify_author_if_draft, which can over-ride the always_notify_author option.

If anyone else is interested in this feature, please let me know if you have any comments.

comment:3 Changed 5 years ago by osimons

The draft plugin is really just an example, and other variations may appear in other plugins. It would seem to me that the general solution would be to have notification plugin check permission to recipients, and only send to recipients that have permission to read the blog post.

Disclaimer: I don't know any FullBlogNotificationPlugin details - only the FullBlogPlugin with sample plugins.

comment:4 Changed 5 years ago by rjollos

  • Owner changed from trickie to rjollos

Reassigning ticket since I am now maintainer of the plugin.

comment:5 Changed 5 years ago by rjollos

  • Component changed from FullBlogNotificationPlugin to FullBlogAnnouncementsPlugin
  • Owner changed from rjollos to doki_pen

Moving this over to the FullBlogAnnouncementsPlugin to work on it there.

comment:6 follow-up: Changed 5 years ago by doki_pen

I have a trunk version of FullBlogAnnouncements in AnnouncerPlugin trunk. Please use that as the base for any >0.11 work that you do.

comment:7 follow-up: Changed 5 years ago by doki_pen

  • Component changed from FullBlogAnnouncementsPlugin to AnnouncerPlugin
  • Owner changed from doki_pen to ixokai

comment:8 in reply to: ↑ 7 Changed 5 years ago by rjollos

Replying to doki_pen: In regard to owner changed from doki_pen to ixokai. in comment:7, did you intend to do that? It might be that the component has not been transferred to you from the previous owner (I saw this behavior with some plugins I adopted), and to fix it you just need to send an email to the tho admin otaku42.

comment:9 in reply to: ↑ 6 Changed 5 years ago by rjollos

Replying to doki_pen:

I have a trunk version of FullBlogAnnouncements in AnnouncerPlugin trunk. Please use that as the base for any >0.11 work that you do.

Sorry that I haven't had any time to follow-up on things lately, but I intend to continue with testing and development soon.

Do you intend to keep all of the plugins with the AnnouncerPlugin? I think that is a good idea, and if you do intend to do that I think it would also be good to remove the existing pages for FullBlogAnnouncementsPlugin and the other AnnouncerPlugin plugins, and make them sub-wiki-pages of the AnnouncerPlugin.

I'd be happy to help with this, I just don't want to do anything with the documentation that is outside of whatever you have in mind.

comment:10 Changed 5 years ago by anonymous

  • Owner changed from ixokai to anonymous
  • Status changed from new to assigned

Sounds good. Don't worry about me, I'm pretty easy going. I'm just happy to have any help that I can get!

comment:11 Changed 5 years ago by rjollos

I'll do the same for the other two AnnouncerPlugin plugins if it looks okay with you.

comment:12 Changed 4 years ago by hasienda

  • Cc doki_pen hasienda added; anonymous removed
  • Keywords blog added
  • Owner changed from anonymous to rjollos
  • Status changed from assigned to new
  • Summary changed from When `draft` is specified in categories, email should not be sent to Don't send blog announcement, when `draft` is specified in categories

This is just a friendly reminder, that things seem to got stuck by not having the right persons filled into the right fields of this ticket.

Ryan shouldn't wait forever, if he's still up for the task of reorganizing wiki pages for AnnouncerPlugin plugins, right? Let him go on, please.

comment:13 Changed 4 years ago by rjollos

Ticket for this same feature in the FullBlogNotificationPlugin is #7604.

comment:14 Changed 4 years ago by doki_pen

Proceed! Proceed!

comment:15 Changed 4 years ago by rjollos

  • Keywords FullBlogPlugin added

comment:16 Changed 4 years ago by doki_pen

So I've resumed work and I'm wondering were we are with this? I like the idea of using permissions to stop drafts from being sent. This is something I will implement globally in announcer via the filter interface (which I was going to drop, but I'm not going to now). On concern I have, although not a big concern, is that the announcement will show the post as modified instead of new when it changes from draft to live. I guess this should really be handled by the event publisher and not announcer. But think about it. When going from draft to live, issue a created event, instead of a modified event. Or even a new type of event called 'published' or something. For now, I'll leave things as is and you'll have to wait for the permissions to be put in place to get this functionality.

comment:17 follow-up: Changed 4 years ago by rjollos

  • Priority changed from normal to high
  • Status changed from new to assigned

comment:18 Changed 3 years ago by rjollos

  • Status changed from assigned to new

comment:19 in reply to: ↑ 17 ; follow-up: Changed 21 months ago by hasienda

  • Priority changed from high to normal

Replying to rjollos:

Obviously not true, sorry. I'm just going through ticket to set the stage for squeezing more Announcer issues as time permits.

comment:20 in reply to: ↑ 19 Changed 21 months ago by rjollos

Replying to hasienda:

Obviously not true, sorry.

I've used the Priority = high on my projects to generate a list what I will work on next. I understand that this will cause problems when collaborating on project, so I will find some other way to track tickets that need attention.

Add Comment

Modify Ticket

Action
as new The owner will remain rjollos.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.