Modify

Opened 5 years ago

Closed 13 months ago

Last modified 13 months ago

#6243 closed task (fixed)

Switch from ClearSilver to Genshi

Reported by: anonymous Owned by: jun66j5
Priority: high Component: TracWikiToPdfPlugin
Severity: blocker Keywords:
Cc: omega_canta@… Trac Release: 0.11

Description

You're using a plugin which requires the Clearsilver template engine and Clearsilver is not installed. Either disable that plugin or install Clearsilver.

With Trac0.11 and Python2.6, I don't install clearsilver anymore. The Trac community recommends to switch to genshi.

http://trac.edgewall.org/wiki/ClearSilver

Attachments (1)

ticket6243-0.11-r11507.diff (9.5 KB) - added by jun66j5 14 months ago.

Download all attachments as: .zip

Change History (20)

comment:1 Changed 4 years ago by rjollos

I'd suggest taking a look at the TracWikiPrintPlugin. We may want to deprecate this plugin in favor of that one.

comment:2 Changed 3 years ago by rjollos

  • Owner changed from diorgenes to rjollos

comment:3 Changed 3 years ago by rjollos

(In [11262]) Refs #6243:

  • Replaced some deprecated calls to the Trac API.
  • Cleaned up imports.
  • Fixed incorrect indentation.

comment:5 Changed 3 years ago by rjollos

(In [11469]) Refs #6243:

  • Fixed indentation.
  • Removed un-needed imports.

comment:6 Changed 3 years ago by rjollos

(In [11472]) Refs #6243:

  • Fixed indentation.

comment:7 Changed 3 years ago by rjollos

(In [11474]) Refs #6243: Tagged trunk with dev.

comment:8 follow-up: Changed 3 years ago by ChrisNelson

At least list ClearSilver as a requirement and provide some guidance on how to get it working. Neither the ClearSilver page not EdgeWall's mention of it says much more than "download it".

comment:9 Changed 3 years ago by rjollos

(In [11507]) Refs #4043, #6243:

  • Removed some needed imports in [11469].
  • When wiki page is created from the Admin panel, the page variables in not passed as a argument in the request. We'll have to find some other way to get it.

comment:10 Changed 2 years ago by rjollos

  • Type changed from defect to task

#10491 closed as a duplicate.

comment:11 Changed 2 years ago by rjollos

  • Cc omega_canta@… added; anonymous removed

#10836 closed as a duplicate.

comment:12 in reply to: ↑ 8 Changed 2 years ago by omega_canta@…

Replying to ChrisNelson:

At least list ClearSilver as a requirement and provide some guidance on how to get it working. Neither the ClearSilver page not EdgeWall's mention of it says much more than "download it".

+1.

On Debian:

$> apt-get install python-clearsilver

That runs OK, but makes no changes on Trac's behaviour. So, i did this other thing:

$> easy_install clearsilver
install_dir /usr/local/lib/python2.6/dist-packages/
Searching for clearsilver
Reading pypi.python.org/simple/clearsilver/
Reading clearsilver.net/
Best match: clearsilver 0.10.1
Downloading willowmail.com/clearsilver/clearsilver-0.10.1.tar.gz
Processing clearsilver-0.10.1.tar.gz
Running clearsilver-0.10.1/setup.py -q bdist_egg --dist-dir /tmp/easy_install-pOGq5v/clearsilver-0.10.1/egg-dist-tmp-3Mo_ZO
sh: configure: not found
sh: make: not found
error: clearsilver/rules.mk: No such file or directory

$>

Then, this other command:

$> pip install clearsilver
Downloading/unpacking clearsilver
  Downloading clearsilver-0.10.1.tar.gz (436Kb): 436Kb downloaded
  Running setup.py egg_info for package clearsilver
    sh: configure: not found
    sh: make: not found
    Traceback (most recent call last):
      File "<string>", line 14, in <module>
      File "/root/build/clearsilver/setup.py", line 29, in <module>
        rules = open("clearsilver/rules.mk").read()
    IOError: [Errno 2] No such file or directory: 'clearsilver/rules.mk'
    Complete output from command python setup.py egg_info:
    sh: configure: not found

sh: make: not found

Traceback (most recent call last):

  File "<string>", line 14, in <module>

  File "/root/build/clearsilver/setup.py", line 29, in <module>

    rules = open("clearsilver/rules.mk").read()

IOError: [Errno 2] No such file or directory: 'clearsilver/rules.mk'

Will post here any update. NOTE: edited some URLs because trac-hacks didn't let me post the raw log saying that, as it had some URLs, it could be spam.

comment:13 Changed 14 months ago by jun66j5

#11359 has been closed as duplicate.

comment:14 Changed 14 months ago by aureo82@…

The thing is that Trac is not supporting Clearsilver anymore and I don't want to mess with different template engines in the server, the simpler for the server the less probable it is going to fail.

So at the end the answer is no Genshi then no plugin.

Changed 14 months ago by jun66j5

comment:15 Changed 14 months ago by jun66j5

I just created patch to port genshi template, ticket6243-0.11-r11507.diff. Could somebody please try it?

comment:16 Changed 13 months ago by rjollos

I tested the patch with Trac 1.0-stable, it works well. Please feel free to commit it!

comment:17 Changed 13 months ago by rjollos

  • Owner changed from rjollos to jun66j5

comment:18 Changed 13 months ago by jun66j5

  • Resolution set to fixed
  • Status changed from new to closed

In 13441:

TracWikiToPdfPlugin: ported to genshi template from clearsilver (fixed #6243)

comment:19 Changed 13 months ago by jun66j5

Thanks for your testing!

Add Comment

Modify Ticket

Action
as closed The owner will remain jun66j5.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.