Modify

Opened 5 years ago

Closed 2 years ago

Last modified 2 years ago

#6994 closed defect (fixed)

Progress indicator does not refresh

Reported by: barthing@… Owned by: jun66j5
Priority: normal Component: TracDragDropPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

Drag and drop a file to a ticket and confirm, the indicator says 0/1 and 90%. Then nothing happens. A reload of the ticket makes the indicator disappear and shows that the file has been successfully attached. Doing the same with more than 1 file: same behavoir. But it seems that dropping more than 3 files is not safe using the "reload-method", mostly there are only 2 files attached.

Using trac 11.5 and firefox Gecko/20100401 Firefox/3.6.3

By the way, great plugin. :-)

Attachments (0)

Change History (12)

comment:1 Changed 5 years ago by jun66j5

  • Status changed from new to assigned

Hi, thanks for your reports.
It's maybe the problem that this plugin doesn't handle complete state...
I fixed the problem. Please try to use r7862.

comment:2 follow-up: Changed 5 years ago by barthing@…

Hi,

tried latest svn-version. Still not working: When I drop a file, the progress indicator appears and stops. Mozilla JS-Console says: tracdragdrop.js reader is null line 186. After a reload the dropped file is attached. But now this only works with 1 file. Dropping more than 1 file results in onyl 1st file being attached.

Line 185: reader = null;
Line 186: if (reader.error) {

Is that intenional?

comment:3 in reply to: ↑ 2 Changed 5 years ago by jun66j5

Hi,

It's not intentional, It's a bug.
In [7872] improved error handling. If you can, please try.

Thanks.

comment:4 Changed 5 years ago by barthing@…

Hi,

JS-error is gone, but progress indicator hasn't improved so far. I disabled all other plugins installed in my environment, but it seems that's not the problem. Can I do certain tests or post some log-snippets, to see what's wrong?

comment:5 Changed 5 years ago by jun66j5

(In [7875]) refs #6994 - Refresh a list of attachments after uploading the files.

comment:6 Changed 5 years ago by jun66j5

Hi,

In r7875, after uploading all your files, the indicator disappears and the list of attachments is refreshed. Please try it. In my environment, it works fine with Firefox and Google Chrome.

Many thanks for your trying and reports.

comment:7 follow-up: Changed 5 years ago by barthing@…

Hi,

Sorry, it's not working for me. Still indicator stucks and nothing happends. Maybe you put in a switch into setup.cfg where you can enable debug messages, so we can see where it stucks.?

comment:8 Changed 5 years ago by anonymous

Hi,

I've tested two constellations:

  • Firefox 3.6.3 (WinXP), trac 0.11.7 and "tracdragdropplugin-r7880.zip". Everything works fine :-)
  • Firefox 3.6.3 (WinXP), trac 0.11.1 and "tracdragdropplugin-r7880.zip" --> crashed immediately after dropping the file and answering the upload question. The crash was something python internally - sorry, I forgot to keep the log.

For me, the crash in 0.11.1 doesn't matter anymore, cause after updating trac to 0.11.7 everythings works smoothly.

Regards

Martin

comment:9 in reply to: ↑ 7 Changed 3 years ago by anonymous

same problem here.
I'm using 0.12.2 & FF 5.0 and the progress is (with one file) 0 / 1 99%
with two files it is 0 / 2 99%

So it seems it can't upload the first file. I'm using tracd behind an apache httpd-reverse proxy

comment:10 Changed 3 years ago by anonymous

It seems this problem only appears for tracd background. I have two same trac environment (apache and tracd). Only tracd has this problem.

comment:11 Changed 2 years ago by jun66j5

  • Resolution set to fixed
  • Status changed from assigned to closed

In the old version, the plugin could not handle Content-Length. As a result, the issue happened.

In the latest, the issue has been fixed. Please try it. Feel free to reopen if the issue still exists.

comment:12 Changed 2 years ago by barthing@…

Now it works. Thanks a lot for this great plugin.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.