Set up database on environment_create()

[pipern]

I think it's nice to avoid an upgrade step if the plugin is enabled when the environment is first created, so I did this:

ticketchangesets/init.py

@@ -36 +36 @@
 
     # IEnvironmentSetupParticipant.
     def environment_created(self):
-        pass
+        """ Called when a new environment is created. Procedure is similar to
+        an environment upgrade, but we also need to commit the changes
+        ourselves. """
+        db = self.env.get_db_cnx()
+        self.upgrade_environment(db)
+        db.commit()
 
     def environment_needs_upgrade(self, db):
         # Is database up to date?

[Mikael Relbe]

If you create an environment from scratch, this plugin cannot be activated. Therefore, the only use case must be when an environment is created with the "--inherit" option. Right?

But the problem is that something goes terribly wrong when I try this with Trac 0.12dev-r9818.

The provided patch is nevertheless a good suggestion, I'll get back when I found the problem with creating inherited environments.

[Mikael Relbe]

The problem was me ;) I'm going to apply the patch now.

[Mikael Relbe]

I think the patch should look like this:

ticketchangesets/init.py

@@ -36 +36 @@
 
     # IEnvironmentSetupParticipant.
     def environment_created(self):
-        pass
+        """Initialise a created environment for this plugin."""
+        @self.env.with_transaction()
+        def do_create(db):
+            self.upgrade_environment(db)
 
     def environment_needs_upgrade(self, db):
         # Is database up to date?

BUT: How can the plugin be activated during the creation of an environment? I cannot verify this code...

[anonymous]

​#T9416 explains the problem, I will fix this when that is fixed first.

[Mikael Relbe]

​[T9847] makes it possible to test this.

[Mikael Relbe]

Fix committed in [8111].