Modify

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#753 closed defect (fixed)

Wrong comment deletion

Reported by: eblot Owned by: coderanger
Priority: normal Component: TicketDeletePlugin
Severity: major Keywords:
Cc: Trac Release: 0.10

Description

In t:ticket:295, when the spam comment is selected for deletion, the wrong comment is selected in the admin page. See comment #17.

Attachments (0)

Change History (3)

comment:1 Changed 8 years ago by eblot

Tested w/ Firefox 2.0 RC1 and Safari 2.0.4 (419.3)

comment:2 Changed 8 years ago by eblot

  • Trac Release changed from 0.9 to 0.10

Ok, I think I understand what's going wrong, as the problem also shows up with other tickets:

Attaching a file create a ticket event in Trac. However, a new attachment is not accounted as a comment, so the comment numbering in Trac skips all attachment events.

The trouble is that the TicketDeletePlugin does not follow the same rule, it counts attachment events as regular comment events, hence the error: each file attached to a ticket produces an offset for TicketDeletePlugin.

Hope this helps.

comment:3 Changed 8 years ago by coderanger

  • Resolution set to fixed
  • Status changed from new to closed

(In [1378]) Don't show attachment "changes" in the delete screen. Fixes #753.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from coderanger. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.