Ticket #753 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Wrong comment deletion

Reported by: eblot Assigned to: coderanger
Priority: normal Component: TicketDeletePlugin
Severity: major Keywords:
Cc: Trac Release: 0.10

Description

In t:ticket:295, when the spam comment is selected for deletion, the wrong comment is selected in the admin page. See comment #17.

Attachments

Change History

10/01/06 13:51:44 changed by eblot

Tested w/ Firefox 2.0 RC1 and Safari 2.0.4 (419.3)

10/01/06 14:51:40 changed by eblot

  • release changed from 0.9 to 0.10.

Ok, I think I understand what's going wrong, as the problem also shows up with other tickets:

Attaching a file create a ticket event in Trac. However, a new attachment is not accounted as a comment, so the comment numbering in Trac skips all attachment events.

The trouble is that the TicketDeletePlugin does not follow the same rule, it counts attachment events as regular comment events, hence the error: each file attached to a ticket produces an offset for TicketDeletePlugin.

Hope this helps.

10/14/06 00:28:06 changed by coderanger

  • status changed from new to closed.
  • resolution set to fixed.

(In [1378]) Don't show attachment "changes" in the delete screen. Fixes #753.

Add/Change #753 (Wrong comment deletion)




Change Properties
Action