Ticket #8577 (new defect)

Opened 2 years ago

Last modified 6 months ago

NameError: when trying to delete a ticket

Reported by: anonymous Assigned to: doki_pen
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords: ticket TypeError
Cc: Trac Release: 0.12

Description (Last modified by rjollos)

I got this error in trunk: 

Trac [/var/trac/tech]> ticket remove 4
NameError: global name 'page' is not defined

Hmm, couldn't copy/paste the patch here, so i will try to attach it as a file.

Attachments

ticket8577.patch (1.9 kB) - added by jc-trachacks_AnnouncerPlugin@jline.com on 03/07/11 19:34:41.

Change History

03/07/11 19:34:41 changed by jc-trachacks_AnnouncerPlugin@jline.com

  • attachment ticket8577.patch added.

(follow-up: ↓ 5 ) 10/15/12 04:53:37 changed by rjollos

#9154 closed as a duplicate, but proposes some alternate patches.

10/15/12 04:55:04 changed by rjollos

  • description changed.

10/15/12 04:59:59 changed by rjollos

#7833 closed as a duplicate.

10/15/12 21:34:52 changed by rjollos

#8065 closed as a duplicate, and it has a patch which we may want to review.

(in reply to: ↑ 1 ; follow-up: ↓ 6 ) 11/02/12 01:55:04 changed by hasienda

Replying to rjollos:

#9154 closed as a duplicate, but proposes some alternate patches.

I think this is actually the better one.

(in reply to: ↑ 5 ; follow-up: ↓ 7 ) 11/02/12 02:13:55 changed by rjollos

Replying to hasienda:

Replying to rjollos:

#9154 closed as a duplicate, but proposes some alternate patches.

I think this is actually the better one.

Are you suggesting the patch in #9154 is better than the patch in this ticket? I hadn't looked closely enough to make a judgement.

(in reply to: ↑ 6 ) 11/02/12 17:20:05 changed by hasienda

  • keywords set to ticket TypeError.

Replying to rjollos:

Replying to hasienda:

Replying to rjollos:

#9154 closed as a duplicate, but proposes some alternate patches.

I think this is actually the better one.

Are you suggesting the patch in #9154 is better than the patch in this ticket? I hadn't looked closely enough to make a judgement.

Yes, indeed. While str() is more of hack, #9154 more accurately points at a dedicated method designed for the purpose. I've already integrated it into my patch stack and tests.

11/08/12 01:38:34 changed by hasienda

(In [12311]) AnnouncerPlugin: Further improve ticket permission checks, refs #5825, #8458 and #8577.

This is a late follow-up to changeset [9813] after more in-deep discussion on permission checking for whole Trac realms and specific Trac resources in #8458. With my original patch proposal from 04-Feb-2011 in mind I call this an aged and really matured changeset, and that's not so bad after all. Furthermore code from [12304] gets improved here as well.

Special thanks to Odd Simon Simonsen, Ryan J. Ollos and Christian Boos for their help on my way towards better understanding Trac permissions.

Add/Change #8577 (NameError: when trying to delete a ticket)




Change Properties
Action